-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search in keybindings editor by pressing keyboard shortcut #57935
Comments
You can now record keys and search them by checking |
This is awesome, thanks! But I wonder if it would be better to use the dialog that pops up for editing, instead of intercepting all keypresses in search. I can toggle this mode on with the keyboard shortcut, but then I'm trapped and I can't disable it, navigate to the results, or do anything else until I grab the mouse and untoggle that button. The modal dialog lets me press esc to close it, then I'm back in normal editing mode. |
@roblourens IMO its not a good user experience to use two different places for searching. I would prefer to be in the same search input to provide filters. Also, coming out of the recording mode is currently supported by typing escape. But you have to type twice and as a side affect it clears the filter which is not good. I will change it to come out of the recording mode as soon as you type escape. |
- Update placeholders and aria labels
But I'm imagining that it would take the input and insert it into the search box. So it wouldn't be two places to search, more like a faster way to type input into the same search box. I think it's confusing that we now have two different experiences for capturing keyboard shortcuts when they basically are trying to do the same thing. |
@roblourens If the dialog just insert it into the search box then I do not understand the need of the dialog? You can do that directly in the search box by enabling the recording mode. Prompting a new input box from an input box is not a good user experience. Please try try the new feature which is already in the dev and see how it is. BTW one feedback I got from the team is to enable the recording mode by default which means with your suggestion we cannot do it. @misolori FYI |
I did try it, and the experience feels weird. I think something that traps keyboard input should be a modal dialog, not just one part of the UI. I press one shortcut to enable it, and a different shortcut to disable it? I'm not sure about enabling it by default, it could be confusing. (But regardless, it's much better than having to type out |
Hmm.. Not convinced. I would prefer single UI element rather multiple. Let me wait for the feedback before doing the change. |
@misolori There is a shortcut to enter in to that mode. |
We discussed this in Redmond standup and I got some similar feedback, that it might be a better experience using the modal dialog to capture keyboard input. |
@roblourens Thanks for running in the stand up there. I will put this in UX channel to gather the feedback. |
Cool feature! |
I type keyboard shortcuts into the keybindings editor pretty often - like
cmd+shift+...
and that can be a lot of typing. And the dialog to add keybindings by pressing them is very niceSo I was thinking, what if I can search for a keybinding by just pressing it? A button in the search bar or some keyboard shortcut can activate that dialog, then I press the shortcut, and it's pasted into the search bar.
The text was updated successfully, but these errors were encountered: