Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in keybindings editor by pressing keyboard shortcut #57935

Closed
roblourens opened this issue Sep 5, 2018 · 12 comments
Closed

Search in keybindings editor by pressing keyboard shortcut #57935

roblourens opened this issue Sep 5, 2018 · 12 comments
Assignees
Labels
feature-request Request for new features or functionality keybindings-editor Keybinding editor issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@roblourens
Copy link
Member

I type keyboard shortcuts into the keybindings editor pretty often - like cmd+shift+... and that can be a lot of typing. And the dialog to add keybindings by pressing them is very nice

image

So I was thinking, what if I can search for a keybinding by just pressing it? A button in the search bar or some keyboard shortcut can activate that dialog, then I press the shortcut, and it's pasted into the search bar.

@roblourens roblourens added feature-request Request for new features or functionality keybindings-editor Keybinding editor issues labels Sep 5, 2018
@sandy081 sandy081 added this to the September 2018 milestone Sep 6, 2018
@sandy081
Copy link
Member

You can now record keys and search them by checking Record Keys action. You can come out of that mode by typing escape once if search box is empty otherwise twice (first to clear the input and next to off the recording). You can also enter into the recording mode using default keybinding alt+k (cmd+alt+k on Mac).

kapture 2018-09-17 at 12 43 56

@sandy081 sandy081 added the verification-needed Verification of issue is requested label Sep 17, 2018
@roblourens
Copy link
Member Author

roblourens commented Sep 17, 2018

This is awesome, thanks! But I wonder if it would be better to use the dialog that pops up for editing, instead of intercepting all keypresses in search. I can toggle this mode on with the keyboard shortcut, but then I'm trapped and I can't disable it, navigate to the results, or do anything else until I grab the mouse and untoggle that button.

The modal dialog lets me press esc to close it, then I'm back in normal editing mode.

@sandy081
Copy link
Member

@roblourens IMO its not a good user experience to use two different places for searching. I would prefer to be in the same search input to provide filters.

Also, coming out of the recording mode is currently supported by typing escape. But you have to type twice and as a side affect it clears the filter which is not good. I will change it to come out of the recording mode as soon as you type escape.

sandy081 added a commit that referenced this issue Sep 17, 2018
- Update placeholders and aria labels
@roblourens
Copy link
Member Author

But I'm imagining that it would take the input and insert it into the search box. So it wouldn't be two places to search, more like a faster way to type input into the same search box. I think it's confusing that we now have two different experiences for capturing keyboard shortcuts when they basically are trying to do the same thing.

@sandy081
Copy link
Member

@roblourens If the dialog just insert it into the search box then I do not understand the need of the dialog? You can do that directly in the search box by enabling the recording mode. Prompting a new input box from an input box is not a good user experience.

Please try try the new feature which is already in the dev and see how it is. BTW one feedback I got from the team is to enable the recording mode by default which means with your suggestion we cannot do it.

@misolori FYI

@roblourens
Copy link
Member Author

roblourens commented Sep 17, 2018

I did try it, and the experience feels weird. I think something that traps keyboard input should be a modal dialog, not just one part of the UI. I press one shortcut to enable it, and a different shortcut to disable it?

I'm not sure about enabling it by default, it could be confusing.

(But regardless, it's much better than having to type out "ctrl+cmd+shift+f10" or whatever by hand!)

@sandy081
Copy link
Member

Hmm.. Not convinced. I would prefer single UI element rather multiple. Let me wait for the feedback before doing the change.

@miguelsolorio
Copy link
Contributor

I actually like that I'm able to enter into this "mode", though I wish I could run a keyboard shortcut to toggle that mode (I know you can tab to the toggle).

I do think that once you're in this mode, we should update the placeholder text to indicate how to exit this mode:

image

@sandy081
Copy link
Member

sandy081 commented Sep 19, 2018

@misolori There is a shortcut to enter in to that mode. alt+k (cmd+alt+k on Mac). Toggling does not work because once you enter into that model all keys are recorded except Escape. I liked to update the message.

@roblourens
Copy link
Member Author

We discussed this in Redmond standup and I got some similar feedback, that it might be a better experience using the modal dialog to capture keyboard input.

@sandy081
Copy link
Member

@roblourens Thanks for running in the stand up there. I will put this in UX channel to gather the feedback.

@alexr00
Copy link
Member

alexr00 commented Sep 26, 2018

Cool feature!

@alexr00 alexr00 added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Sep 26, 2018
@alexr00 alexr00 removed their assignment Sep 26, 2018
@alexr00 alexr00 added the verification-needed Verification of issue is requested label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality keybindings-editor Keybinding editor issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants