Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholders order #58267

Closed
Capidunord opened this issue Sep 8, 2018 · 4 comments
Closed

Placeholders order #58267

Capidunord opened this issue Sep 8, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug snippets verified Verification succeeded

Comments

@Capidunord
Copy link

Issue Type: Bug

I have two snippets (for latex documents) defined in latex.json snippets file :

{
    "pth": {
		"prefix": "pth",
		"body": "\\pth{$1}$0"
	},
    "interval": {
		"prefix": "interval",
		"body": "\\itv{${1:left}}{${2:right}}{${3:left_value}}{${4:right_value}}$0"
	}
}

There is something I don't understand concerning placeholders order.

If I use the "interval" snippet alone, there is no problem : using TAB, I can switch placeholders in expected order : 1:left->2:right->3:left_value->4:right_value->0.

But if I use the "pth"snippet, then, inside of this snippet, if I trigger the "interval" snippet, I would expect being able to browse placeholders in the same order than in the previous case, however it's not the case : the actual order is 1:left->2:right**->0->**3:left_value->4:right_value->0(from pth snippet)

vscode placeholders order

Is this a bug or is there something I did not understand ?

VS Code version: Code 1.27.1 (5944e81, 2018-09-06T09:21:18.328Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i5-7300HQ CPU @ 2.50GHz (4 x 2496)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.83GB (10.25GB free)
Process Argv C:\Users\steph\AppData\Local\Programs\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%
Extensions (7)
Extension Author (truncated) Version
latex-workshop Jam 5.8.2
vscode-language-pack-fr MS- 1.27.2
python ms- 2018.8.0
csharp ms- 1.15.2
autodocstring njp 0.2.3
vscode-docker Pet 0.2.0
ayu tea 0.16.0

(1 theme extensions excluded)

@vscodebot vscodebot bot added the new release label Sep 8, 2018
@jrieken jrieken added snippets bug Issue identified by VS Code Team member as probable bug labels Sep 10, 2018
@jrieken
Copy link
Member

jrieken commented Sep 10, 2018

Yeah, that order is actually quite weird...

@vscodebot vscodebot bot removed the new release label Sep 11, 2018
@jrieken jrieken added this to the September 2018 milestone Sep 12, 2018
@jrieken
Copy link
Member

jrieken commented Sep 12, 2018

@Capidunord Thanks for reporting this! I have just pushed a fix and it will be available in tomorrows Insider build. Please give it a try: https://code.visualstudio.com/insiders/

@Capidunord
Copy link
Author

Now working as expected in insiders build, many thanks !

@jrieken jrieken added the verified Verification succeeded label Sep 13, 2018
@jrieken
Copy link
Member

jrieken commented Sep 13, 2018

Thanks for using Insiders!

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug snippets verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants