Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Padding and Searchboxes Polishes #58531

Closed
chpxu opened this issue Sep 12, 2018 · 2 comments
Closed

Padding and Searchboxes Polishes #58531

chpxu opened this issue Sep 12, 2018 · 2 comments
Assignees
@miguelsolorio
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue ux User experience issues verified Verification succeeded
Milestone
October 2019

Comments

@chpxu
Copy link

chpxu commented Sep 12, 2018

Issue Type: Polish
Continuation of #58445 except to meet the guidelines.

In every sidebar view, the margin of searchboxes is off. In the majority of cases, the right side of the input has less space than the left side. Additionally (and most apparent in the Extensions view), bottom margin is also too small compared to the rest of the spacing. The solution would simply be to increase the margin on the right-hand side of searchboxes by about 5px? And on the bottom about the same.
@miguelsolorio miguelsolorio added the ux User experience issues label Sep 13, 2018
@miguelsolorio miguelsolorio added this to the Backlog milestone Sep 13, 2018
@miguelsolorio miguelsolorio added the under-discussion Issue is under discussion for relevance, priority, approach label Sep 17, 2018
@miguelsolorio
Copy link
Contributor

I should be able to tweak the margins so they're all consistent:

image

@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 8, 2019
@miguelsolorio miguelsolorio modified the milestones: Backlog, October 2019 Oct 8, 2019
@miguelsolorio
Copy link
Contributor

Cleaned up the margins so that all of the views with an input box up top are the same. The Search view has an exception where it requires more margins due to the expand/collapse chevron:

image

FYI @roblourens @joaomoreno @sandy081

@octref octref added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miguelsolorio miguelsolorio

Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue ux User experience issues verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@octref @chpxu @miguelsolorio