Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gear doesnt appear on settings that take boolean #58538

Closed
ramya-rao-a opened this issue Sep 12, 2018 · 6 comments
Closed

Gear doesnt appear on settings that take boolean #58538

ramya-rao-a opened this issue Sep 12, 2018 · 6 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
September 2018

Comments

@ramya-rao-a
Copy link
Contributor

Issue Type: Bug

  • Open new settings editor
  • Hover over a setting that takes text value. Observe the gear
  • Hover over a setting that takes boolean i.e it has a check box. Observe no gear

VS Code version: Code - Insiders 1.28.0-insider (31bf4cc, 2018-09-12T05:18:53.705Z)
OS version: Windows_NT x64 10.0.17134
@vscodebot vscodebot bot added the insiders label Sep 12, 2018
@ramya-rao-a ramya-rao-a added settings-editor VS Code settings editor issues and removed insiders labels Sep 12, 2018
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Sep 12, 2018
@roblourens roblourens added this to the September 2018 milestone Sep 12, 2018
@itamark
Copy link
Contributor

itamark commented Sep 17, 2018

@ramya-rao-a @roblourens okay if I take a try at this?

@roblourens
Copy link
Member

If you can do it within the next couple days, go ahead 😁

But it's annoying me and I need to fix it soon.

@roblourens
Copy link
Member

The bool control needs an element like this for the toolbar: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/preferences/browser/settingsTree.ts#L616

Which should be created here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/preferences/browser/settingsTree.ts#L788

Then some CSS rules may need to be tweaked, I'm not sure.

@itamark
Copy link
Contributor

itamark commented Sep 17, 2018

😁 @roblourens I'll do my best.

@roblourens roblourens mentioned this issue Sep 19, 2018
Closed
@itamark
Copy link
Contributor

itamark commented Sep 20, 2018 •
edited

Hey - @roblourens @ramya-rao-a I see the issue in insiders build, but can't see it in OSS build - do you?

screen shot 2018-09-20 at 10 05 57 am

@roblourens
Copy link
Member

I can, I actually fixed it yesterday (and just pushed the commit) sorry

@mjbvz mjbvz added the verified Verification succeeded label Sep 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
4 participants
@roblourens @itamark @mjbvz @ramya-rao-a