Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no error when installing extension with disabled dependency #58775

Closed
Spongman opened this issue Sep 16, 2018 · 2 comments
Closed

no error when installing extension with disabled dependency #58775

Spongman opened this issue Sep 16, 2018 · 2 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Milestone
September 2018

Comments

@Spongman
Copy link

Spongman commented Sep 16, 2018 •
edited

@ivankravets, re #platformio/platformio-vscode-ide#339

Issue Type: Bug

to repro:

  • fresh VS install
  • install ms-vscode.cpptools
  • disable ms-vscode.cpptools
  • install platformio.platformio-ide

NOTE: installation is successful, no error. however, the extension fails to activate:

console.ts:136 [Extension Host] Extension 'platformio.platformio-ide' failed to activate. Reason: unknown dependency 'ms-vscode.cpptools'.
  1. there should be messaging that indicates to the user that required dependency extensions are disabled, and installing the extension would likely result in failure.
  2. also, there should be an option, when installing, to enable the full tree of disabled dependency extensions.

VS Code version: Code 1.27.1 (5944e81, 2018-09-06T09:21:18.328Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM)2 Quad CPU @ 2.66GHz (4 x 2671)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: unavailable_software
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 8.00GB (3.79GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe E:\play\p5.js
Screen Reader no
VM 0%
Extensions (7)
Extension Author (truncated) Version
gitlens eam 8.5.6
beautify Hoo 1.4.3
cpptools ms- 0.18.1
platformio-ide pla 1.2.0
ts-extract-interface ril 0.1.2
stylelint shi 0.43.0
shader sle 1.1.3
@vscodebot vscodebot bot added the extensions Issues concerning extensions label Sep 16, 2018
@sandy081 sandy081 added feature-request Request for new features or functionality bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Sep 17, 2018
@sandy081 sandy081 added this to the September 2018 milestone Sep 17, 2018
@roblourens
Copy link
Member

@sandy081 it looks like it just forcibly enables the c++ extension, is that right? Is there anything else I expect to see? It's surprising that it would reenable the c++ extension with no warning, when I just disabled it.

@roblourens roblourens added the verification-steps-needed Steps to verify are needed for verification label Sep 28, 2018
@sandy081
Copy link
Member

@roblourens You are right. But it is same as installing a dependency extension. I would not like to introduce prompts and go this as default behaviour.

@roblourens roblourens added the verified Verification succeeded label Sep 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
3 participants
@roblourens @Spongman @sandy081