Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybindings smoketest is broken #58858

Closed
roblourens opened this issue Sep 18, 2018 · 2 comments
Closed

Keybindings smoketest is broken #58858

roblourens opened this issue Sep 18, 2018 · 2 comments
Assignees
@sandy081
Milestone
September 2018

Comments

@roblourens
Copy link
Member

https://vscode.visualstudio.com/VSCode/_build/results?buildId=7197&view=logs

Error: Active element not found. Current active element is 'HTML > BODY.monaco-shell.vs-dark.vscode-theme-defaults-themes-dark_plus-json.file-icons-enabled > DIV#workbench.main.container.monaco-workbench.mac.nopanel > DIV#workbench.parts.editor.part.editor.has-watermark > DIV.content > DIV.grid-view-container > DIV.monaco-grid-view > DIV.monaco-grid-branch-node > DIV.monaco-split-view2.vertical.separator-border > DIV.split-view-container > DIV.split-view-view > DIV.editor-group-container.active > DIV.editor-container > DIV#workbench.editor.keybindings.editor-instance > DIV.keybindings-editor > DIV.keybindings-header > DIV.search-container > DIV.settings-header-widget > DIV.settings-search-container > DIV.settings-search-input > DIV.monaco-inputbox.idle.synthetic-focus > DIV.wrapper > INPUT.input'. Looking for .settings-search-input input
@roblourens roblourens added this to the September 2018 milestone Sep 18, 2018
@roblourens roblourens self-assigned this Sep 18, 2018
@roblourens
Copy link
Member Author

I don't understand what's going on, it's looking for a selector to be active, .settings-search-input input, which is clearly in the current active element.

I think this is from 86ae8ff but I don't see how. It doesn't look like the DOM structure changed at all.

@roblourens roblourens assigned sandy081 and unassigned roblourens Sep 21, 2018
@roblourens roblourens changed the title Settings smoketest is broken Keybindings smoketest is broken Sep 21, 2018
@sandy081
Copy link
Member

Its because the query selector for Search input box is matching the input box of the update dialog. Fixed it.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 8, 2018
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@sandy081
Fix microsoft#58858
a92b31d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
2 participants
@roblourens @sandy081