Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab tooltip shows different contents based on exact mouse positioning #58864

Closed
Adam13531 opened this issue Sep 18, 2018 · 3 comments
Closed

Tab tooltip shows different contents based on exact mouse positioning #58864

Adam13531 opened this issue Sep 18, 2018 · 3 comments
Assignees
@bpasero
Labels
debt Code quality issues workbench-tabs VS Code editor tab issues
Milestone
September 2018

Comments

@Adam13531
Copy link

Issue Type: Bug

Video repro: https://clips.twitch.tv/DeafHyperYamTinyFace

Text repro:

  1. Open SCM
  2. Click a file that has changes. Not sure if it matters, but my workbench.editor.enablePreview is false.
  3. Hover over the resulting tab in the padding beneath the text in the tab.

Expected: it shows the same results as if you'd hovered over the text in the tab (which is the full path to the file)
Actual: it shows the text in the tab (which is just the name of the file). See the picture below for more information:

image

VS Code version: Code 1.27.1 (5944e81, 2018-09-06T09:21:18.328Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.93GB (8.27GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%
Extensions (29)
Extension Author (truncated) Version
Bookmarks ale 9.1.0
snapshot-tools asv 0.0.7
multi-cursor-case-preserve Car 1.0.4
bracket-pair-colorizer Coe 1.0.60
sql-formatter cym 1.0.2
transformer dak 1.6.0
vscode-eslint dba 1.6.0
githistory don 0.4.2
gitlens eam 8.5.6
prettier-vscode esb 1.6.1
vscode-eval exp 1.2.1
vscode-todo-plus fab 4.4.4
vscode-pull-request-github Git 0.1.5
toggler hid 0.0.3
vscode-power-mode hoo 2.2.0
vscode-insertdatestring jsy 2.2.3
center-editor-window kai 2.1.1
theme-karyfoundation-themes kar 18.2.1
contextualduplicate laf 0.2.0
expand-region let 0.1.2
codeacejumper luc 1.1.8
indent-rainbow ode 7.2.4
dumb-copy-paste she 1.0.0
incremental-search sie 0.2.1
vscode-autohotkey sle 0.2.2
rewrap stk 1.9.1
transpose v4r 0.0.5
vscode-vtools ven 1.0.4
change-case wma 1.0.0

(8 theme extensions excluded)
@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno Sep 19, 2018
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-tabs VS Code editor tab issues labels Sep 19, 2018
@bpasero
Copy link
Member

bpasero commented Sep 19, 2018

This is probably caused by the file label to decide to use a different label compared to the tab. @isidorn do you know why the hover is the same if tabs are disabled but different when tabs are enabled? Since you last touched the file label for fixing label issues, maybe this is a recent thing that changed?

@bpasero bpasero added this to the September 2018 milestone Sep 19, 2018
@isidorn
Copy link
Contributor

isidorn commented Sep 19, 2018

@bpasero all good now?

@bpasero
Copy link
Member

bpasero commented Sep 19, 2018

@isidorn yes, turns out I was not setting the title for the ResourceLabel when tabs are disabled. I changed that now.

@bpasero bpasero added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Sep 19, 2018
bpasero added a commit that referenced this issue Sep 19, 2018
@bpasero
better fix #58864
5f15e3e
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
debt Code quality issues workbench-tabs VS Code editor tab issues
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @isidorn @Adam13531