Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit QuickPickItem.shouldAlwaysShow #59232

Closed
chrmarti opened this issue Sep 24, 2018 · 3 comments
Closed

Revisit QuickPickItem.shouldAlwaysShow #59232

chrmarti opened this issue Sep 24, 2018 · 3 comments
Assignees
@chrmarti
Labels
api api-finalization debt Code quality issues quick-pick Quick-pick widget issues
Milestone
October 2018

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Sep 24, 2018 •
edited

The name doesn't match any existing API. alwaysShow might do it. (This might have slipped in by accident. @joaomoreno #58730)
@chrmarti chrmarti added api quick-pick Quick-pick widget issues labels Sep 24, 2018
@chrmarti chrmarti self-assigned this Sep 24, 2018
@chrmarti chrmarti added this to the September 2018 milestone Sep 24, 2018
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Sep 24, 2018
@chrmarti
Copy link
Contributor Author

Moving to proposed API for September. The new QuickInput API will also need to pass the flag.

chrmarti added a commit that referenced this issue Sep 24, 2018
@chrmarti
Revisit QuickPickItem.shouldAlwaysShow (#59232)
eaddbde
@chrmarti chrmarti modified the milestones: September 2018, October 2018 Sep 24, 2018
@oneslash
Copy link
Contributor

Sorry guys for inconvenience

@chrmarti
Copy link
Contributor Author

@oneslash No worries, your work is appreciated. I'm just being picky about the naming in the API.

chrmarti added a commit that referenced this issue Oct 1, 2018
@chrmarti
QuickPickItem.alwaysShow (#59232)
54c51f2
@chrmarti chrmarti mentioned this issue Oct 2, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
api api-finalization debt Code quality issues quick-pick Quick-pick widget issues
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
2 participants
@chrmarti @oneslash