Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why the flashing when option change in find widget? #59316

Closed
isidorn opened this issue Sep 25, 2018 · 7 comments
Closed

Why the flashing when option change in find widget? #59316

isidorn opened this issue Sep 25, 2018 · 7 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations ux User experience issues verified Verification succeeded
Milestone
September 2018

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 25, 2018 •
edited

Refs: #59265

  1. Open find widget
  2. Use shortcut to change state, for example alt + r or (cmd + alt + r on mac)
  3. Notice the find widget flashing

The find widget does not flash if I change state when I click.
I guess the idea is to draw attention that the state changed, however this just looks bad to me and we do not do this sort of ux in other parts of the product.
IMHO we should remove the flashing and just not treat this case specialy
Also we do not flash in the find widget in the terminal which I think is correct @alexr00

fyi @misolori

flashing
@isidorn isidorn added the editor-find Editor find operations label Sep 25, 2018
@rebornix
Copy link
Member

I don't know why/when this flashing was added but @misolori can decide if we want to remove it.

@rebornix rebornix added ux User experience issues under-discussion Issue is under discussion for relevance, priority, approach labels Sep 25, 2018
@miguelsolorio
Copy link
Contributor

We should remove it since it's not a pattern we currently use and the focus state is enough of an indicator.

It also appears that @alexandrudima added it a while back with 3357ae8, maybe some context would help decide it.

@rebornix rebornix assigned alexdima and rebornix and unassigned rebornix Sep 26, 2018
@roblourens
Copy link
Member

I was thinking it was just added this month, is it possible that it's a feature that was just recently enabled? No way it's been like that since Jan 2017! But yeah the search view should match too.

@roblourens
Copy link
Member

roblourens commented Sep 26, 2018 •
edited

@rebornix ade3856

@rebornix
Copy link
Member

Thanks @roblourens , it looks like a side effect of these two commits, I'll take a look.

@isidorn
Copy link
Contributor Author

isidorn commented Sep 27, 2018

Seems like a regression than, I suggest to assign it to September

@rebornix rebornix added this to the September 2018 milestone Sep 27, 2018
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Sep 28, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Sep 28, 2018

Adding bug label so this gets verfieid

@isidorn isidorn added the verified Verification succeeded label Sep 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations ux User experience issues verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
5 participants
@roblourens @rebornix @isidorn @alexdima @miguelsolorio