Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs in diff editor: navigate while keeping diff #59332

Closed
bpasero opened this issue Sep 25, 2018 · 3 comments
Closed

Breadcrumbs in diff editor: navigate while keeping diff #59332

bpasero opened this issue Sep 25, 2018 · 3 comments
Assignees
Labels
breadcrumbs bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@bpasero
Copy link
Member

bpasero commented Sep 25, 2018

Verifying #57594

  • Open a diff with outline
  • Use the outline to navigate to symbols of the file
  • Select a symbol
  • 馃悰 you are navigating to the file

I would expect to navigate within the diff on the right hand side.

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug breadcrumbs labels Sep 25, 2018
@jrieken jrieken added this to the September 2018 milestone Sep 25, 2018
@jrieken
Copy link
Member

jrieken commented Sep 25, 2018

I would expect to navigate within the diff on the right hand side.

Me too

@jrieken
Copy link
Member

jrieken commented Sep 25, 2018

@bpasero Is that something that the editor service supports via some kind of option or is this something that needs alex-editor knowledge?

@bpasero
Copy link
Member Author

bpasero commented Sep 25, 2018

@jrieken we have a similar problem for the editor commands that start a navigation (e.g. "Go to definition"). If the definition is in the same file, we do not want to exit the diff editor. All of the editor commands leverage ICodeEditorService.openCodeEditor() for this purpose. This one is implemented in the workbench to support diff editors. Can you give it a try and see if that works? It should be a drop-in replacement for IEditorService#openEditor() for the basic scenarios of opening text editors. It will forward to the IEditorService.openEditor() if there is no diff editor involved.

@bpasero bpasero added the verified Verification succeeded label Sep 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breadcrumbs bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants