-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert workbench editor actions to commands #59346
Comments
Assigning to october so I tackle my part then |
I pushed the changes for the diff editor to fix #59338 |
I looked into the Running Extensions and that whole view is an old school pain. I actually started to convert but requires some work since the actions currently in the title area of the running extensions view dynamically update their label and icons. So we would need to split them up in multiple commands. |
@isidorn can you give an overview of how the actions change exactly? would it help if some actions moved into the "..." menu instead of being primary? |
Extension host profile actions changes from start debugging to stop debugging. Code pointer |
@isidorn so it is just this one action? Then just add a context key for this scenario. |
Done |
Thanks! |
The following editors are using old-school actions and should change to a model where a command is contributed to the editor title area:
Example of a good contribution: link
Once this is in, the editor part can remove calls to
getActions()
,getSecondaryActions()
fromComposite
.The text was updated successfully, but these errors were encountered: