Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert workbench editor actions to commands #59346

Closed
3 tasks done
bpasero opened this issue Sep 25, 2018 · 8 comments
Closed
3 tasks done

Convert workbench editor actions to commands #59346

bpasero opened this issue Sep 25, 2018 · 8 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Sep 25, 2018

The following editors are using old-school actions and should change to a model where a command is contributed to the editor title area:

Example of a good contribution: link

Once this is in, the editor part can remove calls to getActions(), getSecondaryActions() from Composite.

@isidorn
Copy link
Contributor

isidorn commented Sep 25, 2018

Assigning to october so I tackle my part then

@isidorn isidorn added this to the October 2018 milestone Sep 25, 2018
@bpasero bpasero removed their assignment Sep 25, 2018
bpasero added a commit that referenced this issue Sep 25, 2018
@bpasero
Copy link
Member Author

bpasero commented Sep 25, 2018

I pushed the changes for the diff editor to fix #59338

@isidorn
Copy link
Contributor

isidorn commented Sep 28, 2018

I looked into the Running Extensions and that whole view is an old school pain.
I think this should be tackled via #57969 @ramya-rao-a

I actually started to convert but requires some work since the actions currently in the title area of the running extensions view dynamically update their label and icons. So we would need to split them up in multiple commands.
Bottom line I think it does not deserve the effort

@bpasero
Copy link
Member Author

bpasero commented Sep 28, 2018

@isidorn can you give an overview of how the actions change exactly? would it help if some actions moved into the "..." menu instead of being primary?

@isidorn
Copy link
Contributor

isidorn commented Oct 1, 2018

Extension host profile actions changes from start debugging to stop debugging. Code pointer
@bpasero if you are passionate about getting rid of this I can do it, but I just did not find it smart to invest in something we should actually get rid of and put in the extensions viewlet.
Moving into the ... would not change much as the title needs to change still and that is not supported by commands, thus two seperate commands would be needed.

@bpasero
Copy link
Member Author

bpasero commented Oct 1, 2018

@isidorn so it is just this one action? Then just add a context key for this scenario.

@sandy081 sandy081 removed their assignment Oct 1, 2018
@sandy081
Copy link
Member

sandy081 commented Oct 1, 2018

Done

@bpasero
Copy link
Member Author

bpasero commented Oct 1, 2018

Thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

3 participants