(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• WebView devtools can dock inside vscode (#59443)
• retainContextWhenHidden should restore focus within the webview as well (#48604)
• Regression: WebView fails to render (#58203)

@sbatten With your work, won't the save menu item be disabled if there is no active editor?

@mjbvz @sbatten

If the plan is to disable it, that may also work in our case. At least that way the user isn't confused, thinking they are saving using the file menu. We can add our own save buttons in the webview in that case.

Closed by mistake

@mjbvz yes, we should add that context key to save and save as...

@sbatten sorry but I had to revert this change as it imho breaks our layers. Checking https://github.com/Microsoft/vscode/wiki/Code-Organization#workbench-parts there is:

think twice before letting a part depend on another part: is that really needed and does it make sense? Can the dependency be avoided by using the workbench extensibility story maybe?

In this case we suddenly make the files contribution depend on the welcome experience. Is that really a good idea? I would prefer a clean solution where e.g. we introduce a new context key that is managed by the workbench and is updated when editors change by asking them if they can be saved or not. This may not exist yet, but we can easily add more methods to editors (or inputs) to support that.

fair enough. I would argue that this isn't a hard dependency in that the removal of the welcome ex does not change its behavior, but I understand the idea. I don't want to be maintaining this list if it grows, either. I did not find a reliable dirtyEditor context key or similar, but we can add one.

isn't a hard dependency in that the removal of the welcome ex does not change its behavior

How is this not a hard dependency? We will not be able to bundle the file explorer alone without the welcome code unless we remove the import statements.

I did not find a reliable dirtyEditor context key or similar, but we can add one.

I think handleContextKeys would be a good start to add this. It is the one that already reacts to editors changing. We can look into this when you are here 👍

We will not be able to bundle the file explorer alone without the welcome code unless we remove the import statements.

My mistake, forgot I actually used the id variable and not just the string literal.