Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workbench navigation sidebar should be sideBar or Side Bar in labels #62270

Closed
isidorn opened this issue Oct 31, 2018 · 3 comments
Closed

Workbench navigation sidebar should be sideBar or Side Bar in labels #62270

isidorn opened this issue Oct 31, 2018 · 3 comments
Assignees
@octref
Labels
polish Cleanup and polish issue
Milestone
October 2018

Comments

@isidorn
Copy link
Contributor

isidorn commented Oct 31, 2018 •
edited

Refs: #62097

Pease change all the names to be sideBarso capital B. Since these are two words across our UX. So the command names to be workbench.action.previousSideBarView and workbench.action.nextSideBarView
The context key to be sideBarFocus

Also change the Label to be Previous Side Bar View and Next Side Bar View

Thanks!
@isidorn isidorn added the polish Cleanup and polish issue label Oct 31, 2018
@isidorn isidorn added this to the October 2018 milestone Oct 31, 2018
@isidorn isidorn mentioned this issue Oct 31, 2018
Closed
2 tasks
@isidorn
Copy link
Contributor Author

isidorn commented Oct 31, 2018

While you are at it you could also change this wronlgy named command
View: maximize editor group and hide sidebar to be
View: maximize editor group and hide side bar

screenshot 2018-10-31 at 12 33 28

@octref
Copy link
Contributor

octref commented Oct 31, 2018

Fixed via fe5db1a. Tagged wrong issue though...

@octref octref closed this as completed Oct 31, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Oct 31, 2018

@octref great, thanks a lot!

octref added a commit that referenced this issue Nov 5, 2018
@octref
sidebarFocus -> sideBarFocus. Part of #62270
108e4d5
octref added a commit that referenced this issue Nov 5, 2018
@octref
sidebarFocus -> sideBarFocus. Part of #62270
fde1277
@octref octref mentioned this issue Nov 5, 2018
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
polish Cleanup and polish issue
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
2 participants
@isidorn @octref