Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved workspace not removed from "recently opened" #62411

Closed
roblourens opened this issue Nov 1, 2018 · 4 comments · Fixed by #64433
Closed

Moved workspace not removed from "recently opened" #62411

roblourens opened this issue Nov 1, 2018 · 4 comments · Fixed by #64433
Assignees
@aeschli @sandy081
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
November 2018

Comments

@roblourens
Copy link
Member

roblourens commented Nov 1, 2018 •
edited

  • Open some foo.code-workspace
  • See that it's in the "Open Recent..." list
  • Close vscode
  • Delete that code-workspace
  • Open vscode
  • Use Open Recent to select that deleted workspace
  • Get a message that foo.code-workspace doesn't exist anymore
  • See Open Recent again - the workspace is still in that list

If I follow the same steps with a folder instead of a workspace, then the folder is removed from the list as I'd expect.
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Nov 18, 2018
@bpasero bpasero added this to the November 2018 milestone Nov 18, 2018
@bpasero
Copy link
Member

bpasero commented Nov 19, 2018

@roblourens I cannot reproduce, tried with insiders on macOS. Here is what I did:

  • open a workspace
  • saved it as another workspace on my desktop
  • closed vscode
  • deleted that workspace
  • opened vscode (opens empty)
  • try to open that deleted workspace via file > open recent
  • dismiss the dialog
  • try to find the entry again

=> it is gone

Since this involves a menu update, could it be that you opened the menu too fast for the menu to update? I think the current delay is like 800ms?

@bpasero bpasero added info-needed Issue requires more information from poster and removed bug Issue identified by VS Code Team member as probable bug labels Nov 19, 2018
@bpasero bpasero removed this from the November 2018 milestone Nov 19, 2018
@roblourens
Copy link
Member Author

Interesting, I am using the "File: Open Recent..." command. When I use that, it isn't removed from the list, but when I use the File > Open Recent menu, it is removed.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Nov 20, 2018
@bpasero bpasero added this to the November 2018 milestone Nov 20, 2018
@bpasero bpasero assigned aeschli and sandy081 and unassigned bpasero Nov 20, 2018
@bpasero
Copy link
Member

bpasero commented Nov 20, 2018

I can reproduce and it seems to be a regression from the work to support URIs on the main side. The flow is:

  • opening the workspace fails and we call remove from recently opened (here)
  • since we pass over a URI we think this is a single folder workspace (which it is not) and fail to remove it

moving to @sandy081 (cc @aeschli)

@sandy081
Copy link
Member

sandy081 commented Dec 5, 2018

This was the change from @aeschli adopting URIs for files.

sandy081 added a commit that referenced this issue Dec 5, 2018
@sandy081
Fix #62411
8022a9d
@sandy081 sandy081 mentioned this issue Dec 5, 2018
Merged
bpasero pushed a commit that referenced this issue Dec 5, 2018
@sandy081 @bpasero
Fix #62411 (#64433)
8708222
@bpasero bpasero added the verified Verification succeeded label Dec 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

Successfully merging a pull request may close this issue.

Fix #62411 microsoft/vscode
4 participants
@roblourens @bpasero @aeschli @sandy081