Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu items with no group specified are now shown in separate groups #62875

Closed
StephenWeatherford opened this issue Nov 9, 2018 · 2 comments
Closed

Menu items with no group specified are now shown in separate groups #62875

StephenWeatherford opened this issue Nov 9, 2018 · 2 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone
October 2018 Reco...

Comments

@StephenWeatherford
Copy link

Issue Type: Bug

Was this an intentional change?

For instance, in the Cosmos DB extension (ms-azuretools.vscode-cosmosdb):

Version: 1.28.2 (user setup):
image

VS Code version: Code - Insiders 1.29.0-insider (5438af1, 2018-11-07T01:01:54.305Z):
image

The corresponding view/item/context items look like:
{
"command": "cosmosDB.copyConnectionString",
"when": "view == cosmosDBExplorer && viewItem == cosmosDBGraphAccount"
},
{
"command": "cosmosDB.createGraphDatabase",
"when": "view == cosmosDBExplorer && viewItem == cosmosDBGraphAccount"
},

System Info
Item Value
CPUs Intel(R) Xeon(R) W-2133 CPU @ 3.60GHz (12 x 3600)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 31.73GB (11.55GB free)
Process Argv --folder-uri file:///c%3A/Users/stephwe/Repos/vscode-docker
Screen Reader no
VM 0%
Extensions (10)
Extension Author (truncated) Version
tslint eg2 1.0.40
vscode-antlr4 mik 2.0.4
vscode-azureappservice ms- 0.9.1
vscode-azurestorage ms- 0.4.2
vscode-cosmosdb ms- 0.8.0
extension-manifest-editor ms- 0.1.5
azure-account ms- 0.6.0
csharp ms- 1.17.0
azurerm-vscode-tools msa 0.4.2
vscode-docker Pet 0.3.1
@vscodebot vscodebot bot added the insiders label Nov 9, 2018
@mkenigs mkenigs mentioned this issue Nov 9, 2018
Closed
@sandy081 sandy081 assigned jrieken and mjbvz and unassigned sandy081 Nov 12, 2018
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Nov 12, 2018
@sandy081
Copy link
Member

sandy081 commented Nov 12, 2018 •
edited

Caused by following change 0ce7bad

https://github.com/Microsoft/vscode/blob/5f24c93878bd4bc645a4a17c620e2487b11005f9/src/vs/platform/actions/common/menu.ts#L37

Tagging this candidate as it is a regression

@jrieken jrieken removed their assignment Nov 12, 2018
@jrieken
Copy link
Member

jrieken commented Nov 12, 2018

@mjbvz please undo that strict null change

@mjbvz mjbvz closed this as completed in 642cbc9 Nov 12, 2018
mjbvz added a commit to mjbvz/vscode that referenced this issue Nov 12, 2018
@mjbvz
Ensure menus with no group specified have property grouping
d777836 
Port of microsoft#62875 to 1.29
@mjbvz mjbvz mentioned this issue Nov 12, 2018
Merged
@mjbvz mjbvz added this to the October 2018 Recovery milestone Nov 12, 2018
@StephenWeatherford StephenWeatherford mentioned this issue Nov 13, 2018
Closed
@mjbvz mjbvz added the verified Verification succeeded label Nov 16, 2018
Logerfo referenced this issue in Logerfo/cd-repo Nov 16, 2018
@Logerfo
fixed scm command not being grouped
75579ba 
I believe this was broken with the 1.29 vscode update, but I could not find anything in the changelog, so I'm not sure
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
October 2018 Recovery
Development

No branches or pull requests
4 participants
@jrieken @StephenWeatherford @sandy081 @mjbvz