Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search sidebar - misplaced error message #63049

Closed
deader115 opened this issue Nov 13, 2018 · 2 comments
Closed

Search sidebar - misplaced error message #63049

deader115 opened this issue Nov 13, 2018 · 2 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone
November 2018

Comments

@deader115
Copy link

deader115 commented Nov 13, 2018 •
edited

Issue Type: Bug

  1. Type anything in search text box
  2. Type a \ in the files to exclude box (this may work with other invalid characters)

As of latest version, \ cannot be used in exclude which is fine (was excluding a directory with this notation previously). However, when the dangling \ is in the "files to exclude" box, the UI error instead shows for the top textbox. I would expect the error to point to the textbox it actually occurs in.

VS Code version: Code 1.29.0 (5f24c93, 2018-11-12T07:46:32.773Z)
OS version: Windows_NT ia32 10.0.14393

System Info
Item Value
CPUs Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.88GB (9.80GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (18)
Extension Author (truncated) Version
project-manager ale 9.1.0
npm-intellisense chr 1.3.0
gitignore cod 0.5.0
bracket-pair-colorizer Coe 1.0.61
vscode-eslint dba 1.7.0
githistory don 0.4.3
gitlens eam 8.5.6
vscode-html-css ecm 0.2.0
EditorConfig Edi 0.12.5
tslint eg2 1.0.40
vscode-npm-script eg2 0.3.5
Angular2 joh 7.0.1
csharp ms- 1.17.0
team ms- 1.144.1
debugger-for-chrome msj 4.11.0
vscode-icons rob 7.28.0
code-spell-checker str 1.6.10
shell-launcher Tyr 0.2.0

image
@roblourens
Copy link
Member

Errors usually can't be resolved to a particular input box so we don't try. But this syntax should work.

@roblourens roblourens self-assigned this Nov 13, 2018
@roblourens roblourens added search Search widget and operation issues bug Issue identified by VS Code Team member as probable bug labels Nov 13, 2018
@roblourens roblourens added this to the November 2018 milestone Nov 13, 2018
@deader115
Copy link
Author

Fair enough, I had a suspicion that behind the scenes this is basically just a single object, making it hard to break apart. Sorry for not understanding that intent.

On the bright side, glad I could help perhaps spot another issue. I simply took off the / and it met my needs so I just assumed it was a slight syntax cleanup.

@vscodebot vscodebot bot removed the new release label Nov 20, 2018
roblourens added a commit that referenced this issue Dec 1, 2018
@roblourens
Fix QB tests, #63049
a4cb12d
@Tyriar Tyriar added the verified Verification succeeded label Dec 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
3 participants
@roblourens @Tyriar @deader115