Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integrated Terminal] Next/Prev panel not switching #63223

Closed
usernamehw opened this issue Nov 15, 2018 · 2 comments
Closed

[Integrated Terminal] Next/Prev panel not switching #63223

usernamehw opened this issue Nov 15, 2018 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone
November 2018

Comments

@usernamehw
Copy link
Contributor

Using kind of similar code to suggested in release notes:

{
    "key": "ctrl+]",
    "command": "workbench.action.nextPanelView",
    "when": "panelFocus"
},
{
    "key": "ctrl+[",
    "command": "workbench.action.previousPanelView",
    "when": "panelFocus"
}

Not working until added to terminal.integrated.commandsToSkipShell. Should they be there by default?
@vscodebot vscodebot bot added the terminal Integrated terminal issues label Nov 15, 2018
@octref octref assigned alexr00 and unassigned octref Nov 16, 2018
@octref
Copy link
Contributor

octref commented Nov 16, 2018

I think the principle is navigation commands should always be skipped. @alexr00 can you add these two commands and workbench.action.[previous|next]SideBarView to the skip commands?

@octref
Copy link
Contributor

octref commented Nov 16, 2018

Also opened #63271...

@Tyriar Tyriar added this to the November 2018 milestone Nov 30, 2018
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Nov 30, 2018
@Tyriar Tyriar closed this as completed in 7cd7e37 Nov 30, 2018
@alexr00 alexr00 removed their assignment Dec 3, 2018
@mjbvz mjbvz added the verified Verification succeeded label Dec 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
5 participants
@Tyriar @octref @usernamehw @mjbvz @alexr00