Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adopt new DAP attribute "runInTerminal.shellProcessId" #63434

Closed
weinand opened this issue Nov 19, 2018 · 5 comments
Closed

adopt new DAP attribute "runInTerminal.shellProcessId" #63434

weinand opened this issue Nov 19, 2018 · 5 comments
Assignees
@weinand
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2018

Comments

@weinand
Copy link
Contributor

weinand commented Nov 19, 2018 •
edited

adopt the new DAP attribute "runInTerminal.shellProcessId" in VS Code.

Corresponding DAP feature request: microsoft/debug-adapter-protocol#12
@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Nov 19, 2018
@weinand weinand added this to the November 2018 milestone Nov 19, 2018
@weinand weinand self-assigned this Nov 19, 2018
@gjsjohnmurray
Copy link
Contributor

Using today's Insiders I confirmed that I get the new shellProcessId attribute. But I also found that the first RunInTerminalRequest that was issued after startup consistently gave a RunInTerminalResponse with "success":false and "message":"terminal shell timeout". Perhaps my environment (Windows 10 x64, and debugging an extension) is too slow, but maybe the 1-second timeout hardcoded as part of e40df57 needs to be longer.

@weinand
Copy link
Contributor Author

weinand commented Nov 22, 2018

Thanks for letting me know. I'll increase the timeout. Coming from macOS I was obviously too optimistic in my guess...

@weinand
Copy link
Contributor Author

weinand commented Nov 22, 2018

Increased timeout to 5 secs.

weinand added a commit that referenced this issue Nov 22, 2018
@weinand
increase timeout for #63434 fix
b7a5edf
@gjsjohnmurray
Copy link
Contributor

That's resolved it for me. Thanks.

@weinand
Copy link
Contributor Author

weinand commented Dec 3, 2018

@gjsjohnmurray thanks for verifying. Added verified label.

@weinand weinand added the verified Verification succeeded label Dec 3, 2018
@roblourens roblourens added the verification-needed Verification of issue is requested label Dec 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
3 participants
@roblourens @weinand @gjsjohnmurray