Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DirtyDiff listener leak? #64238

Closed
jrieken opened this issue Dec 3, 2018 · 2 comments
Closed

DirtyDiff listener leak? #64238

jrieken opened this issue Dec 3, 2018 · 2 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug perf scm General SCM compound issues verified Verification succeeded
Milestone
November 2018

Comments

@jrieken
Copy link
Member

jrieken commented Dec 3, 2018

Found this in the console after typing for while...

/Users/jrieken/Code/vscode/out/vs/base/common/event.js:113 [5gh] potential listener LEAK detected, having 398 listeners already. MOST frequent listener (299):
LeakageMonitor.check @ /Users/jrieken/Code/vscode/out/vs/base/common/event.js:113
/Users/jrieken/Code/vscode/out/vs/base/common/event.js:114     at TextModel.onDidChangeContent (file:///Users/jrieken/Code/vscode/out/vs/editor/common/model/textModel.js:230:39)
    at file:///Users/jrieken/Code/vscode/out/vs/workbench/parts/scm/electron-browser/dirtydiffDecorator.js:871:71
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
@jrieken
Copy link
Member Author

jrieken commented Dec 3, 2018

Setting a breakpoint shows a fishy amount of listeners...

screenshot 2018-12-03 at 17 39 40

@joaomoreno joaomoreno added this to the November 2018 milestone Dec 3, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug perf scm General SCM compound issues labels Dec 3, 2018
@mjbvz mjbvz mentioned this issue Dec 4, 2018
Closed
@jrieken jrieken added the verified Verification succeeded label Dec 6, 2018
@jrieken
Copy link
Member Author

jrieken commented Dec 6, 2018

verified via review

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug perf scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
2 participants
@joaomoreno @jrieken