Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select options remain open when navigating away from settings editor #64265

Closed
RMacfarlane opened this issue Dec 4, 2018 · 6 comments · Fixed by #64271
Closed

Select options remain open when navigating away from settings editor #64265

RMacfarlane opened this issue Dec 4, 2018 · 6 comments · Fixed by #64271
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug dropdown DropDown (SelectBox widget) native and custom issues settings-editor VS Code settings editor issues verified Verification succeeded
Milestone

Comments

@RMacfarlane
Copy link
Contributor

Issue Type: Bug

  1. Open the settings editor
  2. Focus a setting that has a dropdown so that the options are displayed
  3. Switch editors

The dropdown remains open:
screen shot 2018-12-03 at 3 59 34 pm

Not sure if this is an issue with the select itself, or the settings editor.

VS Code version: Code - Insiders 1.30.0-insider (9e62a05, 2018-12-03T06:12:08.874Z)
OS version: Darwin x64 18.0.0

@RMacfarlane RMacfarlane added settings-editor VS Code settings editor issues dropdown DropDown (SelectBox widget) native and custom issues labels Dec 4, 2018
@vscodebot vscodebot bot added the insiders label Dec 4, 2018
@roblourens
Copy link
Member

roblourens commented Dec 4, 2018

Nice, for me it even jumps to the corner of the screen for some reason after switching to the editor.

image

@cleidigh I think we will need some way to hide the list when the settings editor hides? Is there a way to force it to hide from outside currently?

@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Dec 4, 2018
@cleidigh
Copy link
Contributor

cleidigh commented Dec 4, 2018

@roblourens
Ha, I was afraid this would occur.
The _sticky flag that Jackson added for debugging was changed to true in a recent PR. I was going to ask if this was intentional. My Insiders was just old enough to not have this.

@joaomoreno was this left as 'true' by mistake when you're doing some mouse work for list?

I will verify if this is the case and fix unless requested otherwise...

cleidigh added a commit to cleidigh/vscode that referenced this issue Dec 4, 2018
@roblourens
Copy link
Member

Good catch, it looks like a mistake, I'll revert it so it can get into tomorrow's build. Let me know if that's not the case @joaomoreno.

@roblourens
Copy link
Member

Actually looks like you are on it @cleidigh, go ahead if you want to create a PR.

@cleidigh
Copy link
Contributor

cleidigh commented Dec 4, 2018

Fixed with, #64271

@cleidigh
Copy link
Contributor

cleidigh commented Dec 4, 2018

@roblourens - you have to merge, I'm not allowed :-(

roblourens added a commit that referenced this issue Dec 4, 2018
SelectBox: Restore _sticky = false. Fixes: #64265
@roblourens roblourens added this to the November 2018 milestone Dec 5, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Dec 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug dropdown DropDown (SelectBox widget) native and custom issues settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants