Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer breaks: workbench depends on ITextFileService #6429

Closed
bpasero opened this issue May 17, 2016 · 0 comments
Closed

Layer breaks: workbench depends on ITextFileService #6429

bpasero opened this issue May 17, 2016 · 0 comments
Assignees
@bpasero
Labels
debt Code quality issues
Milestone
Backlog

Comments

@bpasero
Copy link
Member

bpasero commented May 17, 2016 •
edited

In: editorStatus and untitledEditorInput

Should either make Untitled a concept of parts/files or make parts/files generic.

Idea
Could also try to move untitled into the file area since it is so closely related.
@bpasero bpasero self-assigned this May 17, 2016
@bpasero bpasero added the debt Code quality issues label May 17, 2016
@bpasero bpasero modified the milestones: Backlog, June 2016 May 17, 2016
@bpasero bpasero modified the milestones: Backlog, June 2016 Jun 3, 2016
@bpasero bpasero modified the milestones: Backlog, July 2016 Jul 1, 2016
@bpasero bpasero modified the milestones: July 2016, Backlog Jul 8, 2016
@bpasero bpasero modified the milestones: Backlog, September 2016 Aug 31, 2016
@bpasero bpasero changed the title Layer break: untitled editor service knows text file service Layer breaks: workbench depends on ITextFileService Sep 9, 2016
@bpasero bpasero modified the milestones: Backlog, September 2016 Sep 12, 2016
@bpasero bpasero closed this as completed in 96f1117 Oct 5, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
debt Code quality issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@bpasero