Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined input variables are silently ignored #64354

Closed
weinand opened this issue Dec 4, 2018 · 1 comment
Closed

undefined input variables are silently ignored #64354

weinand opened this issue Dec 4, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Dec 4, 2018

testing #64214:

  • in a task use an input variable with an unknown name ${input:unknown}
  • run the task

Observe:

  • the variable is not substituted and there is no error popping up.

Since a task with an unresolved variable makes no sense (and might be even dangerous if the ${...} is passed to a real shell) I suggest to popup an error alert (not a notification) indicating a need for immediate attention.

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels Dec 5, 2018
@alexr00 alexr00 added this to the November 2018 milestone Dec 5, 2018
@alexr00 alexr00 closed this as completed in 8b0480d Dec 5, 2018
@weinand
Copy link
Contributor Author

weinand commented Dec 6, 2018

@alexr00 Works fine now.
But there is an inconsistency between tasks and debug:
In tasks an easy to miss notification appears, whereas in debug an alert shows up.

@weinand weinand added the verified Verification succeeded label Dec 6, 2018
@roblourens roblourens added verified Verification succeeded and removed verified Verification succeeded labels Dec 7, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants