Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input variable type names are very generic #64359

Closed
weinand opened this issue Dec 4, 2018 · 2 comments
Closed

input variable type names are very generic #64359

weinand opened this issue Dec 4, 2018 · 2 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone
November 2018

Comments

@weinand
Copy link
Contributor

weinand commented Dec 4, 2018

testing #64214:

input variable type names "prompt" and "pick" are very broad and generic.

Since I can imagine that the next feature request will ask for a file picker, a folder picker, and a general process picker, I wonder whether we could come up with more specific names that leave room for other future pickers and prompts.
@weinand weinand changed the title input variable types are very generic input variable type names are very generic Dec 4, 2018
@alexr00 alexr00 added the tasks Task system issues label Dec 5, 2018
@alexr00
Copy link
Member

alexr00 commented Dec 5, 2018

How about "promptString" and "pickString"?

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Dec 5, 2018
@alexr00 alexr00 added this to the November 2018 milestone Dec 5, 2018
@weinand
Copy link
Contributor Author

weinand commented Dec 5, 2018

yep, I like that!

@alexr00 alexr00 closed this as completed in 51ef43a Dec 5, 2018
@weinand weinand added the verified Verification succeeded label Dec 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
2 participants
@weinand @alexr00