Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API documentation for "retrigger" events incomplete #64432

Closed
weinand opened this issue Dec 5, 2018 · 0 comments
Closed

API documentation for "retrigger" events incomplete #64432

weinand opened this issue Dec 5, 2018 · 0 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
November 2018

Comments

@weinand
Copy link
Contributor

weinand commented Dec 5, 2018

testing #64278:

The comment for SignatureHelpContext.isRetrigger says:

Retriggers occur when the signature help is already active and can be caused by typing a trigger character or by a cursor move.

My experiments showed that in addition to the two reasons mentioned above retriggers occur for document changes too: if I press "deleteRight" (which doesn't move the cursor), I still get retrigger events.
@weinand weinand mentioned this issue Dec 5, 2018
Closed
2 tasks
@mjbvz mjbvz added this to the November 2018 milestone Dec 5, 2018
@mjbvz mjbvz added verification-needed Verification of issue is requested bug Issue identified by VS Code Team member as probable bug and removed verification-needed Verification of issue is requested labels Dec 5, 2018
@mjbvz mjbvz closed this as completed in 8f7bd57 Dec 5, 2018
@weinand weinand added the verified Verification succeeded label Dec 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
2 participants
@weinand @mjbvz