Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple navtree request made in js/ts files #64570

Closed
mjbvz opened this issue Dec 7, 2018 · 3 comments
Closed

Multiple navtree request made in js/ts files #64570

mjbvz opened this issue Dec 7, 2018 · 3 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
November 2018

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Dec 7, 2018 •
edited

Issue Type: Bug

Repo

  1. Set:
"typescript.tsserver.trace": "verbose",
"javascript.referencesCodeLens.enabled": true,
  1. In a js file:
export function foo() { }
  1. Open the TypeScript output panel
  2. Clear panel
  3. Make a single text change

Bug
Search TypeScript output and see multiple navtree requests being made for the same file. We should only make one

VS Code version: Code - Insiders 1.30.0-insider (048fdbb, 2018-12-06T06:11:56.829Z)
OS version: Darwin x64 18.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 3
Memory (System) 16.00GB (0.06GB free)
Process Argv -psn_0_8870005
Screen Reader no
VM 18%
@mjbvz mjbvz added this to the November 2018 milestone Dec 7, 2018
@mjbvz mjbvz self-assigned this Dec 7, 2018
@vscodebot vscodebot bot added the insiders label Dec 7, 2018
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Dec 7, 2018
@mjbvz
Copy link
Contributor Author

mjbvz commented Dec 7, 2018 •
edited

This is a regression for November. Navtree is generally quite fast but can be expensive on larger documents. And we are now potentially making an extra request on all typing events

@mjbvz
Copy link
Contributor Author

mjbvz commented Dec 7, 2018

Extra requests are also made when just moving the cursor through the file

@mjbvz mjbvz closed this as completed in 07f6967 Dec 7, 2018
@isidorn isidorn added the verified Verification succeeded label Dec 7, 2018
@isidorn
Copy link
Contributor

isidorn commented Dec 7, 2018

There is only one navTree request, adding verified label

screenshot 2018-12-07 at 14 48 11

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
2 participants
@isidorn @mjbvz