Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac error when updating while offline #64739

Closed
roblourens opened this issue Dec 10, 2018 · 1 comment
Closed

Mac error when updating while offline #64739

roblourens opened this issue Dec 10, 2018 · 1 comment
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release install-update VS Code installation and upgrade system issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone
November 2018

Comments

@roblourens
Copy link
Member

roblourens commented Dec 10, 2018 •
edited

From #60966

I see this on Mac:

  • Go offline
  • Click "Check for updates"
  • In devtools:
  ERR context is not defined: ReferenceError: context is not defined
    at t.onError (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:347:147)
    at e.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:123:532)
    at AutoUpdater.r (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:129:235)
    at emitTwo (events.js:126:13)
    at AutoUpdater.emit (events.js:214:7)

After this, the menu item says "Checking for updates..." forever until I reload the window.
@roblourens
Copy link
Member Author

https://github.com/Microsoft/vscode/blob/master/src/vs/platform/update/electron-main/updateService.darwin.ts#L49

This builds because context is a global from mocha

@joaomoreno joaomoreno added this to the December 2018 milestone Dec 11, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues macos Issues with VS Code on MAC/OS X labels Dec 11, 2018
@joaomoreno joaomoreno added the candidate Issue identified as probable candidate for fixing in the next release label Dec 11, 2018
joaomoreno added a commit that referenced this issue Dec 11, 2018
@joaomoreno
fixes #64739
552023e
joaomoreno added a commit that referenced this issue Dec 11, 2018
@joaomoreno
Merge pull request #64803 from Microsoft/joao/release/1.30/fix-64739
c6e592b 
Fixes #64739
@rebornix rebornix added the verified Verification succeeded label Dec 11, 2018
@joaomoreno joaomoreno mentioned this issue Dec 12, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release install-update VS Code installation and upgrade system issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
3 participants
@joaomoreno @roblourens @rebornix