Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peek view tree sometimes scrolls when collapsing elements #65319

Closed
roblourens opened this issue Dec 18, 2018 · 1 comment
Closed

Peek view tree sometimes scrolls when collapsing elements #65319

roblourens opened this issue Dec 18, 2018 · 1 comment
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug editor-symbols definitions, declarations, references tree-widget Tree widget issues verified Verification succeeded
Milestone
February 2019

Comments

@roblourens
Copy link
Member

  • Trigger find all references on something with a long list
  • Move focus down in the list with arrow keys
  • Expand a row
  • Sometimes, the list scrolls back to up to the top. But the focused element stays at the same spot.
  • Sometimes it doesn't happen when expanding but does when collapsing

Doesn't happen 100% of the time, not sure what's going on...

This is Severity.Error in severity.ts

dec-18-2018 11-09-12
@jrieken jrieken added tree-widget Tree widget issues editor-symbols definitions, declarations, references labels Dec 19, 2018
@jrieken jrieken added this to the December/January 2019 milestone Dec 19, 2018
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Dec 19, 2018
@jrieken jrieken assigned joaomoreno and unassigned jrieken Dec 19, 2018
@jrieken
Copy link
Member

jrieken commented Dec 19, 2018

@joaomoreno This is the tree giving me a change event for the wrong item. Steps

  • peek references on Severity.Error (see how Error is focused)
  • arrow down to terminalTaskSystem
  • arrow right to expand that node
  • 🐛 the tree fires a select change event for Severity.Error

screenshot 2018-12-19 at 10 08 22

@roblourens roblourens mentioned this issue Feb 18, 2019
Closed
@joaomoreno joaomoreno mentioned this issue Feb 22, 2019
Closed
@mjbvz mjbvz added the verified Verification succeeded label Feb 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug editor-symbols definitions, declarations, references tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
4 participants
@joaomoreno @roblourens @jrieken @mjbvz