Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invisible element is focused when SCM split view is collapsed #65585

Closed
Tyriar opened this issue Dec 22, 2018 · 6 comments
Closed

Invisible element is focused when SCM split view is collapsed #65585

Tyriar opened this issue Dec 22, 2018 · 6 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug splitview-widget Splitview UI system issues verified Verification succeeded
Milestone
February 2019

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 22, 2018

Repro:

  1. Open SCM viewlet
  2. Collapse git pane
  3. Press shift+tab a few times and tab a few times, notice that there's an element that can be focused in between the 2 headers. document.activeElement points at this, which appears to be a tree inside the pane:

screen shot 2018-12-21 at 10 19 20 pm
@joaomoreno joaomoreno added this to the December/January 2019 milestone Jan 3, 2019
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Jan 3, 2019
bpasero added a commit that referenced this issue Jan 30, 2019
@bpasero
fix #65585
8502bc7
@bpasero
Copy link
Member

bpasero commented Jan 30, 2019

@joaomoreno PR #67548

@joaomoreno joaomoreno added splitview-widget Splitview UI system issues and removed git GIT issues labels Jan 30, 2019
@joaomoreno
Copy link
Member

joaomoreno commented Jan 30, 2019 •
edited

This applies to all panels: SCM, Extensions viewlet, Debug, etc...

@bpasero
Copy link
Member

bpasero commented Jan 30, 2019

Oh wow, then I looked at the wrong place (https://github.com/Microsoft/vscode/blob/9606490e26f8cbe4d615305389d45e9b144ded7c/src/vs/workbench/browser/parts/views/customView.ts#L319).

@sandy081 this would probably be a candidate for moving into a reusable space if possible.

@sandy081
Copy link
Member

Every view has to show/hide their widgets on visibility change. This will be too much to abstract as each view has its own widgets like tree, list etc.,

@bpasero
Copy link
Member

bpasero commented Jan 30, 2019 •
edited

@sandy081 well, now that I am thinking about it, why is the splitview not hiding the body on collapse, wouldn't that be the best general solution? Imho does not make a lot of sense that each customer needs to hide their stuff.

@joaomoreno
Copy link
Member

joaomoreno commented Jan 31, 2019 •
edited

Exactly what I came here to say: @bpasero is right, the Panel should take its own body out of the DOM when hidden.

@joaomoreno joaomoreno mentioned this issue Jan 31, 2019
Closed
sandy081 pushed a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
@joaomoreno @sandy081
fixes microsoft#65585
3d548f3
@Tyriar Tyriar added the verified Verification succeeded label Feb 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug splitview-widget Splitview UI system issues verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @Tyriar @sandy081