-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify context menu actions on editor/group actions #6596
Comments
@stevencl @bgashler1 actually "Close All Editors" would actually close every editor across all groups and not just within the group. I would say it is equally a destructive change of layout as "Close All Editors in Group" is as long as we do not have support for empty groups. Honestly we did not prompt for closing editors and layouts before and people did not ask for it, I wonder why we would change this now? |
@bgashler1 @stevencl when @joaomoreno tested this today (i looked over his shoulder) we also wondered if there should be a "Close All Editors" on the overflow menu of a group because people might misunderstand it as a way to close all editors of the group. Maybe we should not have the other close actions in there? |
Outcome from the UX meeting:
|
@isidorn by reducing the number of actions in the context menu in "Opened Editors" I decided that we do not need the context menu there anymore. Now it looks like this: Which matches pretty much what we had in working files: |
Looks good to me, I like that the change from what we had previously is minimal. |
Related #6536
Steps to Reproduce:
I found it a little too easy to accidentally close all the editors in the entire window.
This could be detrimental to a user's layout. Therefore, I think we should prompt confirmation before closing all editors (as it is sort of a destructive change). No need to prompt for closing all editors in group, though, as that is less destructive.
@stevencl do you agree?
Just my opinion: Also, what I was expecting to be at the bottom of this list was "Close All Editors in Group," as that's a command I would use frequently (and the bottom of a context menu is so easy to hit without thinking).
The text was updated successfully, but these errors were encountered: