Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify context menu actions on editor/group actions #6596

Closed
bgashler1 opened this issue May 20, 2016 · 5 comments
Closed

Simplify context menu actions on editor/group actions #6596

bgashler1 opened this issue May 20, 2016 · 5 comments
Assignees
Labels
ux User experience issues workbench-tabs VS Code editor tab issues
Milestone

Comments

@bgashler1
Copy link
Contributor

bgashler1 commented May 20, 2016

Related #6536

  • VSCode Version: commit 5376d6d
  • OS Version: Mac OS X

Steps to Reproduce:

  1. Open multiple editor groups
  2. Click on the command overflow (ellipses) button

I found it a little too easy to accidentally close all the editors in the entire window.

screen shot 2016-05-20 at 3 47 17 pm

This could be detrimental to a user's layout. Therefore, I think we should prompt confirmation before closing all editors (as it is sort of a destructive change). No need to prompt for closing all editors in group, though, as that is less destructive.

@stevencl do you agree?

Just my opinion: Also, what I was expecting to be at the bottom of this list was "Close All Editors in Group," as that's a command I would use frequently (and the bottom of a context menu is so easy to hit without thinking).

@bgashler1 bgashler1 added the ux User experience issues label May 20, 2016
@bgashler1 bgashler1 changed the title Editor Stacks: "Close All Editors" command to easy to press Editor Stacks: "Close All Editors" command too easy to press May 20, 2016
@bpasero
Copy link
Member

bpasero commented May 21, 2016

@stevencl @bgashler1 actually "Close All Editors" would actually close every editor across all groups and not just within the group. I would say it is equally a destructive change of layout as "Close All Editors in Group" is as long as we do not have support for empty groups.

Honestly we did not prompt for closing editors and layouts before and people did not ask for it, I wonder why we would change this now?

@bpasero bpasero added the workbench-tabs VS Code editor tab issues label May 21, 2016
@bpasero bpasero modified the milestones: Backlog, June 2016 May 21, 2016
@bpasero
Copy link
Member

bpasero commented May 24, 2016

@bgashler1 @stevencl when @joaomoreno tested this today (i looked over his shoulder) we also wondered if there should be a "Close All Editors" on the overflow menu of a group because people might misunderstand it as a way to close all editors of the group. Maybe we should not have the other close actions in there?

@bpasero bpasero changed the title Editor Stacks: "Close All Editors" command too easy to press Simplify context menu actions on editor/group actions May 25, 2016
@bpasero
Copy link
Member

bpasero commented May 25, 2016

Outcome from the UX meeting:

  • we will shorten the names of the actions when they appear in their context
    • editor: close, close others, (close all?)
    • editor shown as tab: additionally "close left", "close right"
    • group: move left, move right, close all
  • we will drop actions that target other contexts (no close all groups, close other groups in the context of editors or groups)

@bpasero
Copy link
Member

bpasero commented May 26, 2016

@isidorn by reducing the number of actions in the context menu in "Opened Editors" I decided that we do not need the context menu there anymore. Now it looks like this:

screen shot 2016-05-26 at 08 22 32

Which matches pretty much what we had in working files:

image

@bpasero bpasero closed this as completed May 26, 2016
@isidorn
Copy link
Contributor

isidorn commented May 26, 2016

Looks good to me, I like that the change from what we had previously is minimal.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ux User experience issues workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

3 participants