-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"go to file" popup cache is cleared periodically (every hour?) #66884
Comments
@twig to be clear, with "cache" you mean this list of recently opened?: |
Not the recently opened list, but an internal list of files in the project (not really sure how else to describe it) Does vscode do a filescan every time we search for files to open? If so, my issue would lie outside of vscode |
Yeah, the search service process shuts down after an hour of no activity, at which point the cache is lost. We had the same discussion in #63094 with another very slow network drive. How slow is the search? To me, that's the real issue. We can get some more info if you
|
@roblourens it's very slow (also a very big JS/front-end project with lots of files) did you want me to time the search on initial load or after an hour of inactivity? quick edit: my assumption was that the quick search would have fallen back to using data from the partially loaded explorer tree while it was still waiting for the scan to finish |
wow my speeds (network drive via local wifi) aren't too bad compared to the other ticket partially warm cache after loading and changing log level to trace
after 1hr of inactivity
|
in the meantime, is there an option for me to increase the timeout to 2hrs to avoid the daily nuisance? |
@chrmarti do you think it would make sense to add a setting that just disables the timeout on the search service process? Ideally search just wouldn't be this slow but I don't know what we can do about this scenario. @twig have you checked that any folders that you don't want to search are properly excluded? It could also be that we are 10000 files that you don't care about. |
yep I've done what I can to reduce network noise
I mean we do have a lot of files in our project, but I've done what I can to help vscode process it (it's become a habit after years of using Eclipse) |
@roblourens Maybe just remove the timeout for all. @twig How many files are in your workspace? Could you check what the |
I could, I think that for most people, if you are like me and have a bunch of idle vscode windows open, it's good to save many MB of memory by getting rid of idle search processes. But I could change the timeout to 3 hours or something. Also we could just publish an extension that periodically runs |
Sorry what am I doing where? Not too familiar with what you're asking me to do
Optional config with current value with default would probably be best for anyone that encounters this issue 🙏 |
I found a way to count the files in the project (via frontend project: 18914 |
You can run |
ooh terminal, gotcha! well, here it is in case you'll find it useful in any way
|
@roblourens Another option might be to persist the cache. That would allow us to lower the timeout, helping with memory footprint across windows and cold-start performance with slow filesystems. I'm fine with a setting for now, if you think that strikes the right balance. |
Persisting the cache is a good idea. I think I'll add a setting for now just so it's usable, this seems to keep coming up. I wish I could repro it to figure out why rg is so slow here. |
@twig @derekwallace You can enable |
Excellent. I'll definitely try that and report back my findings.
…On Wed 6 Feb 2019, 19:07 Rob Lourens ***@***.*** wrote:
@twig <https://github.com/twig> @derekwallace
<https://github.com/derekwallace> You can enable
search.maintainFileSearchCache in the next Insiders build and that should
prevent the cache from being cleared. That doesn't really solve the problem
but should help you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#66884 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFUOVkqaHQEGceV22vzlTyMK2AcpSICBks5vKygAgaJpZM4aL7CJ>
.
|
Before I set up my own build of vscode and manually debug it, is there any other ways for me to provide details which may assist? |
I don't think you will get much from building vscode. Here's something you can do though:
However, my guess is that we will just see that the shared drive is slow and there isn't much that can be done. |
strange, I get this error message when trying it on the insider build
|
search service is taking about 34-37mb of memory the rg process is given these args
|
With insiders you will have to use rg.exe is using very little CPU. I think that is more evidence that the bottleneck is the network. |
ahh good to know yep, thought that'd be the case. |
some regressions I noticed so far
|
Interesting, this setting should not impact that, but if you are seeing a consistent difference you could file a separate issue.
That just sounds like the setting isn't working? How is it different from what you see without the setting? |
With the setting disabled, it works as it does in stable release:
With the setting enable:
I'm not sure what was changed but it feels like the cache is being cleared more often. |
Im having issues with insiders build see #68280 From what i can see the new option makes no difference. in fact i dont think ive ever got results from the cache. iv eonly ever seen recently used files. i checkec that rg.exe does run and completes (after many minutes). no cache with ctrl-p. |
does the change really work? |
No it seems to have made no difference. |
Gonna close this issue as remote dev via ssh has significantly improved my workflow Feel free to re-open if needed |
Issue Type: Performance Issue
I'm not 100% on when the cache is cleared, but it feels like when I come back from lunch it needs a refresh.
Setup:
Is there a setting I can use to tweak this behaviour?
VS Code version: Code 1.30.2 (61122f8, 2019-01-07T22:54:13.295Z)
OS version: Windows_NT x64 10.0.17763
Extensions (3)
The text was updated successfully, but these errors were encountered: