Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid: preferred size of sidebar not working? #67367

Closed
bpasero opened this issue Jan 29, 2019 · 0 comments
Closed

Grid: preferred size of sidebar not working? #67367

bpasero opened this issue Jan 29, 2019 · 0 comments
Assignees
@joaomoreno @sbatten
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Milestone
July 2019

Comments

@bpasero
Copy link
Member

bpasero commented Jan 29, 2019

Refs #67308

  • open files explorer
  • double click on the sash that divides the sidebar to the editor
  • 馃悰 the sidebar appears very large, does not seem like it picks the preferred size of the sidebar which should be the size to show all elements within without scrolling
@sbatten sbatten added layout General VS Code workbench layout issues bug Issue identified by VS Code Team member as probable bug labels Jan 29, 2019
@joaomoreno joaomoreno added this to the July 2019 milestone Jul 22, 2019
@joaomoreno joaomoreno self-assigned this Jul 22, 2019
joaomoreno added a commit that referenced this issue Jul 26, 2019
@joaomoreno
remove EditorPart._preferredSize
916287f 
related to #67367
@lramos15 lramos15 added the verified Verification succeeded label Jul 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Milestone
July 2019
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @lramos15 @sbatten