Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New explorer: do not re-select files that got deleted #68101

Closed
bpasero opened this issue Feb 7, 2019 · 2 comments
Closed

New explorer: do not re-select files that got deleted #68101

bpasero opened this issue Feb 7, 2019 · 2 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone
February 2019

Comments

@bpasero
Copy link
Member

bpasero commented Feb 7, 2019

I am not sure if this was a missing file event, but I noticed that when returning back to the explorer from an "undo all changes" in the SCM view, many errors popped up about a file no longer existing when trying to open it.

I know we should reopen the last selected file in the explorer when returning to it, but we also need to check if that file got deleted meanwhile.

Filing this as a reminder to check if that logic is still in.
@bpasero bpasero added the file-explorer Explorer widget issues label Feb 7, 2019
@isidorn isidorn added this to the February 2019 milestone Feb 18, 2019
@isidorn
Copy link
Contributor

isidorn commented Feb 25, 2019

@bpasero looking at the code it is not possible for something like that to happen.
We just take what is focused in the explorer and try to open it
This might be a dup of missing file events #68316

My point is, are you still seeing this and if yes can you give exact steps?
Or at least errors from console?

@isidorn isidorn added the info-needed Issue requires more information from poster label Feb 25, 2019
@bpasero
Copy link
Member Author

bpasero commented Feb 25, 2019

@isidorn yes reproduces:

  • create a file "1" in a folder
  • do not open it
  • right click it so that it gets focus
  • click on SCM view
  • undo all changes
  • click back to explorer

=> error pops up

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Feb 25, 2019
@octref octref added the verified Verification succeeded label Feb 27, 2019
This was referenced Mar 4, 2019
Merged
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
3 participants
@bpasero @isidorn @octref