-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using key chord when file tree is focused triggers file highlighting #68171
Comments
(Experimental duplicate detection) |
As a temporary work-around you can disable highlight/filtering in the tree. Change the setting "workbench.list.keyboardNavigation": "simple" |
@pedro-pedrosa I can only reproduce if the |
Currently set to highlight.
Anything else you'd like me to check? |
If I change it to simple it both triggers the chord and selects a file. If I change it to filter, it doesn't trigger the chord and starts filtering the file tree, same behaviour as highlight. |
I'm able to reproduce this issue in latest Insiders build.
I have If I switch it to
VS Code version: Code - Insiders 1.32.0-insider (1c50a87, 2019-02-08T06:16:17.233Z) System Info
|
I've noticed one more thing:
|
I can confirm. Steps:
The workaround provided by kieferrm works for me, which is to define in
As @pedro-pedrosa and @IllusionMH note, pressing @heihachi88 Please create a separate issue regarding the terminal. For the explorer, please try the workaround |
|
Disabling features is not a workaround. |
I can repro this on Windows, but not on macOS and Linux. |
@alexandrudima Check out what I get with Ctrl K. Ctrl-F17?! 🤔 Investigating... |
@alexandrudima Found the issue. I was passing a raw I'll close this with that fix... but you might want to look into it. |
@joaomoreno That is crazy, I didn't realize TS would find those to be compatible... Thanks for the heads up. I've pushed 2ff5d6b which makes it more obvious and found another bad usage :/ 2ff5d6b#diff-2203e613237f08bd954dd0a758dfffb4R360 |
Issue Type: Bug
When focusing the file tree pane, hitting the "Save all" chord
Ctrl+K
-S
triggers the file highlighting feature when theS
key is pressed, making it impossible to use the chord.VS Code version: Code 1.31.0 (7c66f58, 2019-02-05T22:35:56.624Z)
OS version: Windows_NT x64 10.0.17134
System Info
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Extensions (3)
The text was updated successfully, but these errors were encountered: