Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vs/base/common/performance fails to run in browser environment #68498

Closed
bpasero opened this issue Feb 12, 2019 · 1 comment
Closed

vs/base/common/performance fails to run in browser environment #68498

bpasero opened this issue Feb 12, 2019 · 1 comment
Assignees
@jrieken
Labels
debt Code quality issues
Milestone
February 2019

Comments

@bpasero
Copy link
Member

bpasero commented Feb 12, 2019

Due to accessing global. Something like this as a workaround:

const safeGlobal = typeof global === 'object' ? global : {};
@bpasero bpasero added the debt Code quality issues label Feb 12, 2019
@jrieken
Copy link
Member

jrieken commented Feb 12, 2019

const safeGlobal = typeof global === 'object' ? global : {};

It's more tricky because the module is being loaded via commonjs and amd but in both worlds they must share the data.

@jrieken jrieken added this to the February 2019 milestone Feb 12, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
debt Code quality issues
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
2 participants
@bpasero @jrieken