Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception popup doesn't appear until navigating to another frame/file then back #68503

Closed
DanTup opened this issue Feb 12, 2019 · 5 comments
Closed

Exception popup doesn't appear until navigating to another frame/file then back #68503

DanTup opened this issue Feb 12, 2019 · 5 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
February 2019

Comments

@DanTup
Copy link
Contributor

DanTup commented Feb 12, 2019 •
edited

This may be related to the changes for #64193 (cc @isidorn). I'm seeing the exception popup not appearing when the top frame has deemphasized source - but if I navigate to another frame (for another file) then back, then it appears.

I've made a repro here:

https://github.com/DanTup/vscode-repro-68503 (changes from mock debug)

It's the Mock Debug project, but I changed it to stop with reason=exception when it hits a breakpoint, and returns deemphasized source for the top frame (I also added a column, since the exception popup didn't seem to show at all without it).

Add a breakpoint somewhere in a .md file and run the debugger. When it gets to the breakpoint it'll show "Stopped on exception" in the call stack, but there is no exception popup:

screenshot 2019-02-12 at 8 56 47 am

However, if I navigate to the top stack frame (which has no source, and shows an appropriate message) and then back to the second stack frame, then the exception popup appears:

screenshot 2019-02-12 at 8 56 58 am
@vscodebot
Copy link

vscodebot bot commented Feb 12, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 12, 2019
@weinand weinand assigned isidorn and unassigned weinand Feb 12, 2019
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Feb 12, 2019
@weinand weinand added this to the February 2019 milestone Feb 12, 2019
@isidorn
Copy link
Contributor

isidorn commented Feb 21, 2019

Thanks for nice repro steps. Try it out in tomorrow's vscode inisders and let us know if the issue is fixed for you.

@DanTup
Copy link
Contributor Author

DanTup commented Feb 21, 2019

Super, will do - thanks!

sandy081 pushed a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
@isidorn @sandy081
fixes microsoft#68503
f512e73
@DanTup
Copy link
Contributor Author

DanTup commented Feb 25, 2019

@isidorn Fix looks good, thanks!

@DanTup DanTup mentioned this issue Feb 25, 2019
Closed
@isidorn
Copy link
Contributor

isidorn commented Feb 25, 2019

Thanks, adding verified label.

@isidorn isidorn added the verified Verification succeeded label Feb 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
3 participants
@DanTup @weinand @isidorn