-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login to Microsoft products aren't working anymore #68531
Comments
@peni4142 For your boss:
For you: Check if your extension uses any native modules. These need to be recompiled for VS Code 1.31. If that's not the cause we need more information on what is going wrong. |
That are dependencies
I don't have written native code on my own. Does that mean I have to wait till third-party modules are recompiled and newly provided? I am using pretty much this code:
snipptet is from: https://stackoverflow.com/questions/51993317/access-sharepoint-document-from-node-js-in-ibm-cloud-function out of the box, it is working. Using it in a VSCode context, it does not work. In one of the out of the box tests, I used NodeJS v10.2.0 as used in VSCode. If it helps I run very frequently |
I'm having the same problem. After updating to the newest version of VSCode, I am unable to connect to TFS using Azure Repos. I downgraded VSCode to the november release (https://code.visualstudio.com/updates/v1_30) and the issue was fixed. My VSCode also auto-updated and the issue reappeared. @chrmarti Thanks for the tip on disabling auto-update. :) |
@chrmarti Oh yes, thanks for the tip. That will help for the showcase. |
@peni4142 Your dependencies could include or depend on native modules. Can you also try with the new proxy support disabled in the settings? |
Yeah that is it. Disabling Proxy Support |
--funny: The German translation of the wording contains different information content than in English. Both describe it more precisely in different respects. |
Is there something I have to do, that it works with the new proxy feature or do you have to fix it? |
@peni4142 Are you or one of the node modules using an |
Working with Authorization-Token. Thats what my header looks like:
|
Seems to be fixed in 1.31.1. |
My co-worker says it still does not work. Did you do something about that? |
@peni4142 Nothing changed in that area between 1.31.0 and 1.31.1. Make sure you have that proxy support set to Can you add error logging to your code, so we see why it fails? |
Another colleague has confirmed this, but apparently, I can not reactivate the feature. That means I can not test whether the problem is resolved. |
I had an empty 401, but I can't reproduce that. Seems I can't reactivate that Feature. |
I am the author of SPGo and I can confirm users who are using NTLM authentication are also experiencing this issue as of VSCode 1.31.x:
@chrmarti I can confirm the workaround of changing the value of My question is why the default value is set to More Context (from chrishasz/spgo#73):
Finally, here is a simple set of reproduction steps you can perform to reproduce the issue:
let credentialOptions = {
domain : 'domain'
password : 'xxxx',
username : 'username'
}
let endpoint = '<ntlm-secured SharePoint site>';
let spr = sprequest.create(credentialOptions);
spr.requestDigest(endpoint)
.then(function(requestResults) {
console.log("auth success!");
console.log("For more, please check the results\n", JSON.stringify(requestResults));
})
.catch(function(err) {
console.log("Core error has happened \n", err);
});
Happy to help debug this further or provide any more info to help resolve as it is affecting a large number of users. updated: added a few clarifying details |
@sg-chrishasz Thanks for the analysis. We figured we can improve the proxy support for all extensions if we override any existing agent (which is often used to support proxies) with our own that can use the OS proxy configuration. It looks like in this case proxies are not necessarily part of the system's configuration. A possible fix appears to be to just use the original agent (e.g., from |
How would it be handled in the future? Do I have to tell everybody to change the proxy entry? or would it be fixed in newer versions? |
@peni4142 The goal is to make it work in newer versions. |
@chrmarti - Thanks for the response. I like the proxy override capability and the original intent makes sense in that context, but definitely think it should not be the default option. Please let us know when you expect an update to the default proxy setting (or similar remediation) to be released. |
"StatusCodeError: 401 - undefined |
@peni4142 @grizzlysol @sg-chrishasz I have added a fix for today's insiders build, could you give that a try and let me know if that fixes the problem with the setting set to 'override'? Download: https://code.visualstudio.com/insiders/ |
@chrmarti I'm Let's wait for confirmation from other guys as well. |
Hello @chrmarti - I can also confirm that NTLM authentication for SPGo is again working in the latest insider's build when proxy is set to Thanks for the quick turn-around! |
Closing as fixed, thanks! |
Marking as verified by users |
Version: 1.31.0 (user setup)
Commit: 7c66f58
Date: 2019-02-05T22:35:56.624Z
Electron: 3.1.2
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17134
Steps to Reproduce:
Did come with the last update. It is very embarrassing that my boss has prepared a showcase and would like to present it very promptly. Since you seem to have introduced an automatic update for all versions, there is no workaround for the meeting. This looks very unprofessional.
Very embarrassing.
I used "https://www.npmjs.com/package/node-sp-auth" for authentification.
Someone else seems to have a problem with TFS:
#68442
The text was updated successfully, but these errors were encountered: