Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to connect to extension marketplace behind proxy #68843

Closed
emilime opened this issue Feb 16, 2019 · 10 comments
Closed

Unable to connect to extension marketplace behind proxy #68843

emilime opened this issue Feb 16, 2019 · 10 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority proxy Issues regarding network proxies verified Verification succeeded
Milestone
February 2019

Comments

@emilime
Copy link

emilime commented Feb 16, 2019

Issue Type: Bug

1 Open marketplace inside VSCode
2 wait for error message in extensions bar

Yes I'm behind a proxy but it always worked up to the version 1.31, starting from version 1.32 it seems broken (in the same LAN obviusly).

VS Code version: Code - Insiders 1.32.0-insider (003521e, 2019-02-15T06:16:29.903Z)
OS version: Windows_NT x64 10.0.17763

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6500U CPU @ 2.50GHz (4 x 2592)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 11.87GB (3.89GB free)
Process Argv
Screen Reader no
VM 0%
@vscodebot vscodebot bot added the extensions Issues concerning extensions label Feb 16, 2019
@sandy081 sandy081 assigned chrmarti and unassigned sandy081 Feb 18, 2019
@sandy081 sandy081 removed the extensions Issues concerning extensions label Feb 18, 2019
@chrmarti chrmarti assigned bpasero and unassigned chrmarti Feb 18, 2019
@chrmarti
Copy link
Contributor

@bpasero This shouldn't be affected by my work which only targets the extension host. Did anything change on Electron's side? /cc @joaomoreno

@bpasero bpasero assigned sandy081 and unassigned bpasero Feb 18, 2019
@bpasero
Copy link
Member

bpasero commented Feb 18, 2019 •
edited

Yes, proxy is reimplemented in Electron 3, it is a possible regression from that update. However, the OP says it works fine in 1.31 (which is Electron 3) and not 1.32 (which we did not udpate Electron).

@sandy081 sandy081 assigned joaomoreno and unassigned sandy081 Feb 19, 2019
@joaomoreno
Copy link
Member

#34385

@emilime emilime mentioned this issue Feb 19, 2019
Open
@emilime
Copy link
Author

emilime commented Feb 20, 2019 •
edited

@joaomoreno I've just installed last Insiders and the bug is still there, sadly from this version I can not use anymore extensions marketplace at work...

@chrmarti chrmarti mentioned this issue Feb 22, 2019
Closed
@chrmarti
Copy link
Contributor

@emilime What kind of proxy is it? What's in your OS' proxy settings?

@emilime
Copy link
Author

emilime commented Feb 22, 2019

@chrmarti the corporate proxy is Squid
In my OS' proxy settings at work, proxy is obviously set in Internet Options so Chrome and all the other sw can see it. My idea is that with version 1.32 these system settings are not read.
Is there any debugging log where I can verify it?

@chrmarti
Copy link
Contributor

@joaomoreno This seems to be a regression in 1.32, not #34385. Did anything change? We are using the XHR for extensions, don't we?

@joaomoreno
Copy link
Member

Did not change anything. Did Electron update?

@chrmarti chrmarti reopened this Feb 27, 2019
@chrmarti chrmarti assigned bpasero and unassigned joaomoreno Feb 27, 2019
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug proxy Issues regarding network proxies labels Feb 27, 2019
@chrmarti chrmarti added this to the February 2019 milestone Feb 27, 2019
@chrmarti chrmarti added the important Issue identified as high-priority label Feb 27, 2019
@chrmarti
Copy link
Contributor

chrmarti commented Feb 27, 2019 •
edited

Found it: 357efea#r32496540

@chrmarti chrmarti mentioned this issue Feb 27, 2019
Closed
@emilime
Copy link
Author

emilime commented Feb 28, 2019

It works now! Thank you!

@octref octref added the verified Verification succeeded label Feb 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority proxy Issues regarding network proxies verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
6 participants
@joaomoreno @emilime @bpasero @octref @chrmarti @sandy081