Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering breadcrumbs to no results shows floating filter popup #68881

Closed
roblourens opened this issue Feb 17, 2019 · 1 comment
Closed

Filtering breadcrumbs to no results shows floating filter popup #68881

roblourens opened this issue Feb 17, 2019 · 1 comment
Assignees
Labels
breadcrumbs bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

  • Open breadcrumbs picker
  • Enable "filter on type"
  • Type a query with no results

image

The breadcrumbs popup disappears and you see "no elements found" and the filter on type popup floating over the editor

@jrieken jrieken added this to the February 2019 milestone Feb 25, 2019
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues breadcrumbs labels Feb 25, 2019
@joaomoreno
Copy link
Member

@jrieken I can fire the onDidChangeContentHeight event in this case. I can take this.

@octref octref added the verified Verification succeeded label Feb 26, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breadcrumbs bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@joaomoreno @roblourens @jrieken @octref and others