Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus is lost when inserting snippets with mouse click #68935

Closed
usernamehw opened this issue Feb 18, 2019 · 3 comments
Closed

Focus is lost when inserting snippets with mouse click #68935

usernamehw opened this issue Feb 18, 2019 · 3 comments
Assignees
@joaomoreno @jrieken
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete ux User experience issues verified Verification succeeded
Milestone
February 2019

Comments

@usernamehw
Copy link
Contributor

Issue Type: Bug

focus

VS Code version: Code - Insiders 1.32.0-insider (bbe40c8, 2019-02-18T10:48:37.179Z)
OS version: Windows_NT x64 10.0.17763
@vscodebot
Copy link

vscodebot bot commented Feb 18, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug ux User experience issues suggest IntelliSense, Auto Complete labels Feb 25, 2019
@jrieken jrieken assigned joaomoreno and jrieken and unassigned jrieken Feb 25, 2019
@jrieken jrieken added this to the February 2019 milestone Feb 25, 2019
@jrieken
Copy link
Member

jrieken commented Feb 25, 2019

@joaomoreno did something in the list change?

@joaomoreno
Copy link
Member

@jrieken It definitely looks like it... thought I don't know what widget, since the suggest widget disables all mouse controlling code from the list and does it itself.

When reading the code, it makes sense that on click the list gets focus. Here's my proposed change, which prevents that behavior: #69348

jrieken added a commit that referenced this issue Feb 25, 2019
@jrieken
Merge pull request #69348 from Microsoft/joao/fix-68935
73e8955 
Fix #68935
@octref octref added the verified Verification succeeded label Feb 26, 2019
@usernamehw usernamehw mentioned this issue Mar 4, 2019
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete ux User experience issues verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
4 participants
@joaomoreno @jrieken @octref @usernamehw