Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit need for electron-browser in workbench/contrib/debug #69104

Closed
bpasero opened this issue Feb 21, 2019 · 1 comment
Closed

Revisit need for electron-browser in workbench/contrib/debug #69104

bpasero opened this issue Feb 21, 2019 · 1 comment
Assignees
@isidorn
Labels
debt Code quality issues
Milestone
March 2019

Comments

@bpasero
Copy link
Member

bpasero commented Feb 21, 2019

Refs #68302

I am not sure why src/vs/workbench/contrib/debug has to have most of its files in electron-browser land. Please consider lifting this to browser if possible.

If there is something blocking this task, speak up and we need to think about introducing new services as needed.
@bpasero bpasero added the debt Code quality issues label Feb 21, 2019
@isidorn isidorn added this to the March 2019 milestone Feb 21, 2019
@bpasero bpasero mentioned this issue Feb 21, 2019
Closed
17 tasks
isidorn added a commit that referenced this issue Mar 14, 2019
@isidorn
debug: use clipboard service
528526d 
#69104
isidorn added a commit that referenced this issue Mar 14, 2019
@isidorn
move debug files
a93905e 
#69104
@isidorn
Copy link
Contributor

isidorn commented Mar 14, 2019

I have moved everything that makes sense to /browser.
Now electron-browser only has the files that spawn process and are tightly coupled with a launching of a debug adapter.

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2019
Development

No branches or pull requests
2 participants
@bpasero @isidorn