Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exceptions from node debug extension on debug start #69128

Closed
isidorn opened this issue Feb 21, 2019 · 2 comments
Closed

Exceptions from node debug extension on debug start #69128

isidorn opened this issue Feb 21, 2019 · 2 comments
Assignees
@weinand
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
February 2019

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 21, 2019

Start debugging a node program
Open dev tools -> notice errors coming from the node extensions

TypeError: Cannot read property 'type' of undefined
	at module.exports.t.initializeAutoAttach.e.subscriptions.push.o.debug.onDidStartDebugSession.e (/Users/isidor/Development/vscode/.build/builtInExtensions/ms-vscode.node-debug/dist/extension.js:1)
	at Emitter.fire (event.js:480)
	at ExtHostDebugService.<anonymous> (/Users/isidor/Development/vscode/out/vs/workbench/api/node/extHostDebugService.js:457)
	at Generator.next (<anonymous>)
	at fulfilled (/Users/isidor/Development/vscode/out/vs/workbench/api/node/extHostDebugService.js:7)

TypeError: Cannot read property 'name' of undefined
	at Function.startSession (/Users/isidor/Development/vscode/.build/builtInExtensions/ms-vscode.node-debug/dist/extension.js:1)
	at module.exports.t.activate.e.subscriptions.push.o.debug.onDidStartDebugSession.e (/Users/isidor/Development/vscode/.build/builtInExtensions/ms-vscode.node-debug/dist/extension.js:1)
	at Emitter.fire (event.js:480)
	at ExtHostDebugService.<anonymous> (/Users/isidor/Development/vscode/out/vs/workbench/api/node/extHostDebugService.js:457)
	at Generator.next (<anonymous>)
	at fulfilled
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 21, 2019
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Feb 21, 2019
@weinand
Copy link
Contributor

weinand commented Feb 21, 2019 •
edited

@isidorn this seems to be a VS Code issue: onDidNewSession receives an undefined session (which should not happen).
I've protected extensions from this and I've added two console.errors when this happens.

@weinand weinand added this to the February 2019 milestone Feb 21, 2019
sandy081 pushed a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
@weinand @sandy081
protect against undefined session; fixes microsoft#69128
69526f5
@roblourens roblourens added the verified Verification succeeded label Feb 26, 2019
@DanTup
Copy link
Contributor

DanTup commented Mar 8, 2019

Is there any more info on what causes this? This fix is throwing errors when launching Dart/Flutter sessions and breaks some of the debugging functionality (see #69534). I can't see what we're doing wrong to trigger it.

@weinand weinand mentioned this issue Mar 8, 2019
Closed
weinand added a commit that referenced this issue Mar 11, 2019
@weinand
remove paranoia code after fix for #69128
37f689c
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
4 participants
@roblourens @DanTup @weinand @isidorn