Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File is reopened after closing then switching viewlets #6922

Closed
stevencl opened this issue May 26, 2016 · 3 comments
Closed

File is reopened after closing then switching viewlets #6922

stevencl opened this issue May 26, 2016 · 3 comments
Assignees
Labels
workbench-tabs VS Code editor tab issues
Milestone

Comments

@stevencl
Copy link
Member

  • VSCode Version:1.1.0-alpha
  • OS Version: Windows 10

If I close a preview file, then switch from the explorer viewlet to another viewlet and then back to explorer, the file I closed reopens again:

reopenfile

@stevencl stevencl added the workbench-tabs VS Code editor tab issues label May 26, 2016
@bpasero
Copy link
Member

bpasero commented May 26, 2016

@stevencl we briefly talked about this during my time in Edinburgh, the explorer is very keen on restoring the context you are in when switching views.

Since now we have an explicit way of closing editors we should maybe revisit this.

@bpasero bpasero added this to the June 2016 milestone May 26, 2016
@stevencl
Copy link
Member Author

Right, but here the context when I leave the explorer is that there are no files open. So I would expect that remains when I go back to the explorer. But instead the file that I had closed before switching to another viewlet is reopened.

@bpasero
Copy link
Member

bpasero commented May 27, 2016

@stevencl would you expect the explorer to also behave this way when it was not visible and you closed all files? So:

  • open search
  • open a file
  • close the file
  • focus explorer

=> should the last file opened in the explorer get visible again?

I now pushed a change to not reopen any file if you closed all files even if the explorer was not visible. I think that helps clearing the clutter.

@bpasero bpasero closed this as completed May 27, 2016
@bpasero bpasero assigned stevencl and unassigned bpasero May 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

2 participants