Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serverReadyAction.uriFormat not respected #69344

Closed
isidorn opened this issue Feb 25, 2019 · 3 comments
Closed

serverReadyAction.uriFormat not respected #69344

isidorn opened this issue Feb 25, 2019 · 3 comments
Assignees
@weinand
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues on-testplan

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 25, 2019

Refs: #69313

The uriFormat is not respected for me, whatever I enter there localhost is opened. Here are my steps

  1. Clone our smoketest experess app https://github.com/Microsoft/vscode/wiki/Smoke-Test
  2. Use the following launch.json
{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "node",
            "request": "launch",
            "smartStep": true,
            "name": "Launch Program",
            "program": "${workspaceFolder}/bin/www",
            "serverReadyAction": {
                "action": "openExternally",
                "pattern": "Port: ([0-9]+)",
                "uriFormat": "http://WRONG:%s",
            }
        }
    ],
}
  1. Notice how the localhost is opened, not my WRONG uri format 🐛
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 25, 2019
@weinand
Copy link
Contributor

weinand commented Feb 25, 2019

@isidorn The name of the property is in fact "urlFormat" (which is consistent because I'm talking about URIs).

@isidorn
Copy link
Contributor Author

isidorn commented Feb 25, 2019

Cool that works now!
So the issue is that in the scheme you are recommending uriFormat it should recommend urlFormat

@weinand
Copy link
Contributor

weinand commented Feb 25, 2019

yep, that's the issue

@weinand weinand mentioned this issue Feb 25, 2019
Closed
2 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues on-testplan
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weinand @isidorn