Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree: Support for automatically expanding parent nodes of filter matches #69352

Closed
egamma opened this issue Feb 25, 2019 · 3 comments
Closed

Tree: Support for automatically expanding parent nodes of filter matches #69352

egamma opened this issue Feb 25, 2019 · 3 comments
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality tree-widget Tree widget issues
Milestone
Backlog

Comments

@egamma
Copy link
Member

egamma commented Feb 25, 2019

Testing #69299

  • enable filtering on type in the outline
  • collapse all nodes using collapse all
  • type a symbol that you know exists that but is collapsed

-> the parent node is not expanded

In this example the symbol type exists, but it is not expanded:

image

image
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug outline Source outline view issues labels Feb 25, 2019
@jrieken jrieken added this to the February 2019 milestone Feb 25, 2019
@jrieken
Copy link
Member

jrieken commented Feb 25, 2019

@joaomoreno is that something the filter controls? how do I achieve this? would I know when filtering happens/happened so that I can call expand all?

joaomoreno added a commit that referenced this issue Feb 26, 2019
@joaomoreno
tree onDidChangeTypeFilterPattern
877f191 
related to #69352
@jrieken
Copy link
Member

jrieken commented Feb 27, 2019

I have pushed a change that restores the old behaviour when filtering but for "type to find" more is needed. Moving to March to the remainder...

jrieken added a commit that referenced this issue Feb 27, 2019
@jrieken
expand nodes when filtering (but not when finding), #69352
c3fdde2
@jrieken jrieken added the tree-widget Tree widget issues label Feb 27, 2019
@jrieken jrieken modified the milestones: February 2019, March 2019 Feb 27, 2019
@jrieken jrieken added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Mar 5, 2019
@jrieken jrieken removed their assignment Mar 5, 2019
@joaomoreno joaomoreno modified the milestones: March 2019, Backlog Mar 8, 2019
@joaomoreno joaomoreno changed the title Outline doesn't expand matching nodes when filtering on type Tree: Support for automatically expanding parent nodes of filter matches Oct 9, 2019
@joaomoreno joaomoreno removed the outline Source outline view issues label Oct 9, 2019
@Gruntfuggly Gruntfuggly mentioned this issue Nov 5, 2019
Closed
@joaomoreno
Copy link
Member

This is now fixed.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality tree-widget Tree widget issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@joaomoreno @egamma @jrieken