Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover actions feedback #69386

Closed
Tyriar opened this issue Feb 25, 2019 · 3 comments
Closed

Hover actions feedback #69386

Tyriar opened this issue Feb 25, 2019 · 3 comments
Assignees
@sandy081 @miguelsolorio
Labels
editor-hover Editor mouse hover polish Cleanup and polish issue
Milestone
February 2019

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 25, 2019 •
edited

#69204

Version: 1.32.0-insider (user setup)
Commit: 393b48d
Date: 2019-02-25T01:34:48.785Z
Electron: 3.1.3
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.18841

While it looks alright here:

image

The actions look particularly ugly when there is a pointer to the file:

image

Not sure if we can do anything to improve just that case.

Also the bottom padding should match the top padding if there is no "status bar" background color.
@sandy081
Copy link
Member

There were some changes to the status bar background which makes it distinguishable from the message.

image

@miguelsolorio
Copy link
Contributor

@sandy081 we should make sure that the text link passes the color contrast ratio with that background color:

image

@sandy081 sandy081 reopened this Feb 25, 2019
@sandy081 sandy081 added editor-hover Editor mouse hover polish Cleanup and polish issue labels Feb 25, 2019
@sandy081 sandy081 added this to the February 2019 milestone Feb 25, 2019
miguelsolorio pushed a commit that referenced this issue Feb 25, 2019
Fix color contrast issues for #69386
5f2ecc8
@miguelsolorio
Copy link
Contributor

Fixed this via 5f2ecc8:

Dark

image

Light

image

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

@miguelsolorio miguelsolorio

Labels
editor-hover Editor mouse hover polish Cleanup and polish issue
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
3 participants
@Tyriar @sandy081 @miguelsolorio