Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick open widget doesn't acknowledge tree.reveal(...) as a promise #696

Closed
joaomoreno opened this issue Nov 26, 2015 · 4 comments
Closed

Quick open widget doesn't acknowledge tree.reveal(...) as a promise #696

joaomoreno opened this issue Nov 26, 2015 · 4 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
Dec 2015

Comments

@joaomoreno
Copy link
Member

There are many calls to tree.reveal(), which all return promises, that are never then-ed:
@joaomoreno joaomoreno mentioned this issue Nov 26, 2015
Closed
@bpasero bpasero assigned joaomoreno and unassigned bpasero Nov 26, 2015
@bpasero
Copy link
Member

bpasero commented Nov 26, 2015

@joaomoreno I fixed those but I see many more in other places, including the tree itself:

image

@joaomoreno
Copy link
Member Author

omglob

@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Nov 27, 2015
@joaomoreno joaomoreno modified the milestone: Dec 2015 Dec 11, 2015
@joaomoreno joaomoreno assigned isidorn and unassigned joaomoreno Dec 15, 2015
@isidorn
Copy link
Contributor

isidorn commented Dec 16, 2015

@joaomoreno I guess these are fine?

screen shot 2015-12-16 at 12 28 19

@isidorn
Copy link
Contributor

isidorn commented Dec 16, 2015

Oopsy ofc they are fine you added a .done

@isidorn isidorn added the verified Verification succeeded label Dec 16, 2015
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
Dec 2015
Development

No branches or pull requests
3 participants
@joaomoreno @bpasero @isidorn