Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer: Regression - Focus Open Editors focuses on files, not editors #69755

Closed
cleidigh opened this issue Mar 4, 2019 · 3 comments
Closed

Explorer: Regression - Focus Open Editors focuses on files, not editors #69755

cleidigh opened this issue Mar 4, 2019 · 3 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release file-explorer Explorer widget issues verified Verification succeeded
Milestone
February 2019

Comments

@cleidigh
Copy link
Contributor

cleidigh commented Mar 4, 2019

Issue Type: Bug

Insiders/OSS of 3-3-19

The focusOpenEditors command no longer focuses on the open editor 's list , rather it focuses on the files view. Neither assigning a different key binding or the command pallet work.

VSC 1.31.1 performs correctly

Steps to reproduce,

  • Issue focusOpenEditors from any context
  • Explorer focuses on the files not the open editors

VS Code version: Code - Insiders 1.32.0-insider (804373a, 2019-03-01T18:22:35.336Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz (12 x 3696)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 31.87GB (17.44GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (31)
Extension Author (truncated) Version
vscode-javascript-snippet-pack aka 0.1.5
Bookmarks ale 10.2.2
pascal ale 8.0.0
pascal-formatter ale 2.1.0
git-easy bib 1.11.0
bracket-pair-colorizer Coe 1.0.61
vscode-eslint dba 1.8.0
gitlens eam 9.5.1
tslint eg2 1.0.43
git-project-manager fel 1.7.1
file-icons fil 1.0.16
vscode-npm fkn 3.3.0
code-runner for 0.9.7
macros ged 1.2.1
vscode-pull-request-github Git 0.4.0
rest-client hum 0.21.1
innosetup idl 1.2.0
csharpfixformat Leo 0.0.78
sftp lix 1.9.5
start-git-bash McC 1.2.1
vscode-remote-workspace mkl 0.41.0
python ms- 2019.2.5416
csharp ms- 1.17.1
debugger-for-chrome msj 4.11.2
vscode-icons rob 8.2.0
git-add-remote sam 0.0.2
code-settings-sync Sha 3.2.5
vscode-hexdump sle 1.7.2
gitblame wad 2.6.3
JavaScriptSnippets xab 1.7.2
markdown-all-in-one yzh 2.1.0

(1 theme extensions excluded)
@cleidigh cleidigh changed the title Explorer: Regression - Focus Open Editors focuses on files, .editors Explorer: Regression - Focus Open Editors focuses on files, not editors Mar 4, 2019
@cleidigh
Copy link
Contributor Author

cleidigh commented Mar 4, 2019

@isidorn
I can look into this directly if you want me to, but I see some structural changes that through me off. A pointer would be sufficient if you want me to chase this.

@isidorn
Copy link
Contributor

isidorn commented Mar 4, 2019

I acknowledge this is a regression.
Thanks for offering to look into this, but I already started on this so I have it covered - thanks!

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues candidate Issue identified as probable candidate for fixing in the next release labels Mar 4, 2019
@isidorn isidorn added this to the February 2019 milestone Mar 4, 2019
@isidorn isidorn mentioned this issue Mar 4, 2019
Merged
@isidorn isidorn closed this as completed in 5893ace Mar 4, 2019
isidorn added a commit that referenced this issue Mar 4, 2019
@isidorn
Merge pull request #69775 from Microsoft/isidorn/doNotFocusAfterPromise
fea4aae 
fixes #69755
isidorn added a commit that referenced this issue Mar 4, 2019
@isidorn
fixes #69755
c3dbfc5
@isidorn isidorn mentioned this issue Mar 4, 2019
Merged
isidorn added a commit that referenced this issue Mar 4, 2019
@isidorn
Merge pull request #69778 from Microsoft/isidorn/openEditorsFocus
4be431d 
fixes #69755
@cleidigh
Copy link
Contributor Author

cleidigh commented Mar 4, 2019

@isidorn Thanks - I missed my editors 👍

@RMacfarlane RMacfarlane added the verified Verification succeeded label Mar 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
3 participants
@isidorn @RMacfarlane @cleidigh