Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated terminal renderer APIs #69865

Closed
Tyriar opened this issue Mar 5, 2019 · 2 comments · Fixed by #78529
Closed

Remove deprecated terminal renderer APIs #69865

Tyriar opened this issue Mar 5, 2019 · 2 comments · Fixed by #78529
Assignees
@Tyriar @alexr00
Labels
api api-proposal debt Code quality issues terminal Integrated terminal issues
Milestone
August 2019

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 5, 2019

Terminal renderers are becoming stable in #67923. TerminalRenderer.terminal and Terminal.onDidWriteData are remaining in proposed to give extensions a chance to migrate over by then.
@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues labels Mar 5, 2019
@Tyriar Tyriar added this to the May 2019 milestone Mar 5, 2019
@Tyriar Tyriar self-assigned this Mar 5, 2019
@Tyriar Tyriar mentioned this issue Mar 5, 2019
Closed
@Tyriar Tyriar modified the milestones: May 2019, June 2019 May 24, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Jun 13, 2019

Blocked on #70978

@Tyriar Tyriar modified the milestones: June 2019, Backlog Jun 13, 2019
@Tyriar Tyriar mentioned this issue Jun 16, 2019
Closed
@Tyriar Tyriar modified the milestones: Backlog, September 2019, August 2019 Aug 5, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Aug 5, 2019

Live share has already adopted vscode.Pseudoterminal so we can remove this in August. FYI @jrieken

Tyriar added a commit that referenced this issue Aug 5, 2019
@Tyriar
Remove terminal renderers
25fe980 
Part of #69865
@Tyriar Tyriar mentioned this issue Aug 5, 2019
Merged
@alexr00 alexr00 mentioned this issue Aug 6, 2019
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@alexr00 alexr00

Labels
api api-proposal debt Code quality issues terminal Integrated terminal issues
Projects
None yet
Milestone
August 2019
Development

Successfully merging a pull request may close this issue.

Remove terminal renderers microsoft/vscode
2 participants
@Tyriar @alexr00