Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix noImplicitAny errors under search #70912

Closed
mjbvz opened this issue Mar 21, 2019 · 0 comments
Closed

Fix noImplicitAny errors under search #70912

mjbvz opened this issue Mar 21, 2019 · 0 comments
Assignees
@roblourens
Labels
debt Code quality issues
Milestone
March 2019

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Mar 21, 2019 •
edited

For #70352

Steps

  1. In ./src/tsconfig.base, change the line "noImplicitAny": false to:

    	"noImplicitAny": true,
	"suppressImplicitAnyIndexErrors": true,

  2. Start a compile

  3. See errors listed under search

Current errors

[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(45,51): Binding element 'inputReg' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(45,61): Binding element 'isMultiline' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(45,74): Binding element 'testStr' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(45,83): Binding element 'shouldMatch' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(69,45): Binding element 'inputReg' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(69,55): Binding element 'isMultiline' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(69,68): Binding element 'testStr' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(69,77): Binding element 'shouldMatch' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(93,33): Binding element 'inputReg' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(93,43): Binding element 'testStr' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(93,52): Binding element 'shouldMatch' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(114,28): Binding element 'inputReg' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(114,38): Binding element 'testStr' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/rawSearchService.test.ts(160,22): Parameter 'match' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/rawSearchService.test.ts(220,14): Parameter 'value' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/rawSearchService.test.ts(246,14): Parameter 'value' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/rawSearchService.test.ts(279,14): Parameter 'value' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/rawSearchService.test.ts(297,15): Parameter 'value' implicitly has an 'any' type.
[09:05:27] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/test/node/rawSearchService.test.ts(326,15): Parameter 'value' implicitly has an 'any' type.

09:25:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/textSearchAdapter.ts(29,15): Parameter 'msg' implicitly has an 'any' type.
[09:25:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/searchService.ts(81,30): Parameter 'progress' implicitly has an 'any' type.
[09:25:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/searchService.ts(145,44): Parameter 'c' implicitly has an 'any' type.
[09:25:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/ripgrepTextSearchEngine.ts(168,2): 'on', which lacks return-type annotation, implicitly has an 'any' return type.
[09:25:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/ripgrepTextSearchEngine.ts(169,2): 'on', which lacks return-type annotation, implicitly has an 'any' return type.
[09:25:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/ripgrepSearchUtils.ts(45,14): Parameter 'line' implicitly has an 'any' type.
[09:25:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/ripgrepSearchUtils.ts(45,29): Parameter 'character' implicitly has an 'any' type.
[09:25:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/rawSearchService.ts(386,9): Parameter 'resolve' implicitly has an 'any' type.
[09:25:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/rawSearchService.ts(386,18): Parameter 'reject' implicitly has an 'any' type.
[09:25:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/rawSearchService.ts(389,10): Parameter 'reject' implicitly has an 'any' type.
[09:25:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/rawSearchService.ts(392,12): Parameter 'onFinally' implicitly has an 'any' type.
[09:25:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/fileSearchManager.ts(347,21): Parameter 'match' implicitly has an 'any' type.
@mjbvz mjbvz added the debt Code quality issues label Mar 21, 2019
@roblourens roblourens added this to the March 2019 milestone Mar 21, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2019
Development

No branches or pull requests
2 participants
@roblourens @mjbvz