Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call Hierarchy: double click on twistie should not go to reference #71142

Closed
bpasero opened this issue Mar 26, 2019 · 4 comments
Closed

Call Hierarchy: double click on twistie should not go to reference #71142

bpasero opened this issue Mar 26, 2019 · 4 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Milestone
June 2019

Comments

@bpasero
Copy link
Member

bpasero commented Mar 26, 2019

Refs: #71083

When you quickly toggle a twistie, it looks like the call is being opened in the editor. This makes it hard to use the twistie after all because sometimes you end up navigating without wanting to.
@jrieken jrieken assigned joaomoreno and unassigned jrieken Mar 26, 2019
@jrieken
Copy link
Member

jrieken commented Mar 26, 2019

@joaomoreno the tree shouldn't emit an dbl-click event when being configured to only expand on twisties

@joaomoreno joaomoreno added this to the March 2019 milestone Mar 26, 2019
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues labels Mar 26, 2019
@joaomoreno joaomoreno modified the milestones: March 2019, Backlog Mar 27, 2019
@DanTup
Copy link
Contributor

DanTup commented Jun 12, 2019

@jrieken what's the status of call hierarchy? It's currently proposed but I couldn't find any obvious issue tracking feedback (though I did find a couple of open bugs like this one). Is it being actively progressed? I'm interested in implementing it, but it might not be worth it yet if it's not likely to ship for a while because of other priorities.

Thanks!

@jrieken
Copy link
Member

jrieken commented Jun 12, 2019

@DanTup ➡️ #70231

@DanTup
Copy link
Contributor

DanTup commented Jun 12, 2019

@jrieken aha, thanks! Not sure how I missed that - good timing. I'll hold off anything until after those changes then 👍

@joaomoreno joaomoreno modified the milestones: Backlog, June 2019 Jun 14, 2019
@bpasero bpasero added the verified Verification succeeded label Jun 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Milestone
June 2019
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @DanTup @jrieken